Skip to content

Instantly share code, notes, and snippets.

@ppcano

ppcano/ember-octane-blueprint-thoughts.md

Last active December 23, 2018 22:46
Show Gist options
  • Save ppcano/4150328dd37e2555b06ab9e4df73adf1 to your computer and use it in GitHub Desktop.
Save ppcano/4150328dd37e2555b06ab9e4df73adf1 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ember-octane-blueprint-thoughts.md

I have reviewed the ember-octane-blueprint project and I have some thoughts that I would like to share:

The ember-octane-blueprint duplicates code from the ember-cli/module-unification-app blueprint; If we want to create tests for the ember-octane-blueprint project, we may end up duplicating the existing MU tests and having to maintain two similar MU app blueprints.

I wonder if a better strategy would be to figure out how the octane-blueprint project could reuse the existing module-unification-app blueprint.

ember new app -b ember-octane-blueprint

The above command could:

  • start a existing module-unification-app blueprint
  • provide additional dependencies (as today)
  • after creating the app, some predefined blueprint (like the Math component) could be run.

Additionally, the addon could provide additional blueprints for example to create sparkles component.

I don’t know exactly if the above flow can be achieved with an Ember addon, otherwise another possible solution could be to change the UX to something like:

ember new app -b module-unification-app
ember generate start-octane

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment