rafaltrojanowski · November 26, 2017 09:27 · Nov 26, 2017 · Nov 26, 2017 · Aug 15, 2017 · Aug 15, 2017
diff --git a/BinaryGaps b/BinaryGaps
@@ -1,5 +1,4 @@
 def solution(n)
-  # write your code in Ruby 2.2
   binary_array = to_binary(n)
 
   i = 0

diff --git a/binary_gaps → BinaryGaps b/binary_gaps → BinaryGaps
@@ -1,6 +1,3 @@
-# you can write to stdout for debugging purposes, e.g.
-# puts "this is a debug message"
-
 def solution(n)
   # write your code in Ruby 2.2
   binary_array = to_binary(n)

diff --git a/binary_gaps b/binary_gaps
@@ -1,11 +1,6 @@
 # you can write to stdout for debugging purposes, e.g.
 # puts "this is a debug message"
 
-
-# 561892, 74901729, 1376796946
-
-
-
 def solution(n)
   # write your code in Ruby 2.2
   binary_array = to_binary(n)
@@ -41,13 +36,10 @@ def to_binary(n)
   arr = []
 
   while n > 0 
-
     i = n % 2 
-
     arr << i
 
     n = n / 2
-
   end
 
   arr

diff --git a/binary_gaps b/binary_gaps
@@ -8,39 +8,32 @@
 
 def solution(n)
   # write your code in Ruby 2.2
-
   binary_array = to_binary(n)
 
-  puts binary_array.inspect
-
-
   i = 0
   j = 0
 
-  counters = []
+  max = 0
   counter = 0
 
   while i < binary_array.size - 1
     counter = 0 
 
-    if binary_array[i] == 1 && binary_array[i+1] == 0
-      puts "I: #{i}"
-
+    if binary_array[i] == 1 && binary_array[i+1] == 0  
       j = i + 1
-
       while binary_array[j] == 0
         counter += 1
-        puts "COUNTER: #{counter}"
         j += 1 
       end
 
-      counters << counter
+      if counter > max
+        max = counter
+      end
     end
-
     i += 1
   end
 
-  counters.max
+  max
 end
 
 

diff --git a/binary_gaps b/binary_gaps
@@ -18,24 +18,29 @@ def solution(n)
   j = 0
 
   counters = []
+  counter = 0
 
-  while j < binary_array.size
-    puts binary_array[j]
+  while i < binary_array.size - 1
+    counter = 0 
 
-    if binary_array[i] == 0
-      i += 1
-      j += 1
-    else # 1 
-      j += 1
-      while binary_array[j] == 0  
-        j +=1
+    if binary_array[i] == 1 && binary_array[i+1] == 0
+      puts "I: #{i}"
+
+      j = i + 1
+
+      while binary_array[j] == 0
+        counter += 1
+        puts "COUNTER: #{counter}"
+        j += 1 
       end
-      i += 1
-      puts "I: #{i}, J: #{j}"
-      counters << j - i 
-    end    
+
+      counters << counter
+    end
+
+    i += 1
   end
-  counters.max  
+
+  counters.max
 end
 
 

diff --git a/binary_gaps b/binary_gaps
@@ -1,6 +1,11 @@
 # you can write to stdout for debugging purposes, e.g.
 # puts "this is a debug message"
 
+
+# 561892, 74901729, 1376796946
+
+
+
 def solution(n)
   # write your code in Ruby 2.2
 

diff --git a/binary_gaps b/binary_gaps
@@ -0,0 +1,51 @@
+# you can write to stdout for debugging purposes, e.g.
+# puts "this is a debug message"
+
+def solution(n)
+  # write your code in Ruby 2.2
+
+  binary_array = to_binary(n)
+
+  puts binary_array.inspect
+
+
+  i = 0
+  j = 0
+
+  counters = []
+
+  while j < binary_array.size
+    puts binary_array[j]
+
+    if binary_array[i] == 0
+      i += 1
+      j += 1
+    else # 1 
+      j += 1
+      while binary_array[j] == 0  
+        j +=1
+      end
+      i += 1
+      puts "I: #{i}, J: #{j}"
+      counters << j - i 
+    end    
+  end
+  counters.max  
+end
+
+
+def to_binary(n)
+  arr = []
+
+  while n > 0 
+
+    i = n % 2 
+
+    arr << i
+
+    n = n / 2
+
+  end
+
+  arr
+end