ramonjoaquim

Checklist para Code Review

Tipos de Campos

• Os tipos de campos estão corretos e adequados ao domínio?
• Há uso desnecessário de tipos primitivos ou wrappers?

Reutilização de Classes

• As classes de consulta estão sendo reutilizadas corretamente?
• Evitou duplicação de lógica em diferentes partes do código?

Padrões de Arquitetura

• O código segue os princípios de Clean Architecture?

ramonjoaquim

<?xml version="1.0" encoding="UTF-8"?>
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
                      https://maven.apache.org/xsd/settings-1.0.0.xsd">
    <mirrors>
        <mirror>
            <id>anupam.com</id>
            <name>anupam</name>
            <url>https://repo.maven.apache.org/maven2/</url>

ramonjoaquim

#!/bin/bash

URL_TOKEN="url webhook from Rocket.Chat"

# Params get by request - add params on zabbix on type of media configuration settings to match a script params
USER="$1"
SUBJECT="$2"
MESSAGE="$3"

# Change color emoji depending on the MESSAGE contains property - Green (RECOVERY), Red (PROBLEM), Yellow (UPDATE)

ramonjoaquim

using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using Microsoft.EntityFrameworkCore;
using Moq;

namespace TestExamples01.Setup
{
    public class Setup
    {        

ramonjoaquim

$Uri = "http://localhost:8080/engine-rest/process-instance/"
$ProcessInstances = Invoke-WebRequest -Uri $Uri | select -ExpandProperty content | ConvertFrom-Json

foreach ($ProcessInstance in $ProcessInstances) {
    Invoke-WebRequest -Method Delete -Uri $($Uri + $ProcessInstance.id)
}

ramonjoaquim

/* 
  ##Device = Desktops
  ##Screen = 1281px to higher resolution desktops
*/

@media (min-width: 1281px) {
  
  //CSS
  

ramonjoaquim

function ExitPageConfirmer(message) {
  this.message = message;
  this.needToConfirm = false;

  var myself = this;

  window.onbeforeunload = function() {
     if (myself.needToConfirm) {
       return myself.message;
     }