00-critic.t

> [08:29:24]:22253 $ prove -Ilib -v xt/00-critic.t 
xt/00-critic.t .. 
1..14
not ok 1 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver.pm"

#   Failed test 'Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver.pm"'
#   at /Users/rbo/Perl/perls/perl-5.12.0/lib/site_perl/5.12.0/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver.pm":
# Private Member Data shouldn't be accessed directly at line 729, column 5.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 729, column 23.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 729, column 51.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 732, column 16.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 732, column 47.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 736, column 34.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 738, column 20.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 738, column 49.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 740, column 9.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 740, column 25.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 740, column 53.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 741, column 77.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 750, column 22.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 752, column 69.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 752, column 86.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 873, column 18.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 875, column 42.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 877, column 18.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 877, column 43.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 877, column 59.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 878, column 28.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 878, column 44.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 886, column 21.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 886, column 46.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 886, column 70.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 886, column 93.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 897, column 61.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 912, column 17.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 970, column 16.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 971, column 16.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 1015, column 25.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 1016, column 34.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 1019, column 25.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 1020, column 34.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
ok 2 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Adaptor.pm"
not ok 3 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console.pm"

#   Failed test 'Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console.pm"'
#   at /Users/rbo/Perl/perls/perl-5.12.0/lib/site_perl/5.12.0/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console.pm":
# Private Member Data shouldn't be accessed directly at line 81, column 25.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 87, column 25.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 93, column 24.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 99, column 21.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 104, column 17.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
not ok 4 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Job.pm"

#   Failed test 'Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Job.pm"'
#   at /Users/rbo/Perl/perls/perl-5.12.0/lib/site_perl/5.12.0/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Job.pm":
# Private Member Data shouldn't be accessed directly at line 281, column 5.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 299, column 19.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 307, column 19.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 314, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 332, column 12.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
ok 5 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Loader.pm"
ok 6 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Observer.pm"
ok 7 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Worker.pm"
ok 8 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Adaptor/PP.pm"
ok 9 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Adaptor/XS.pm"
not ok 10 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console/Basic.pm"

#   Failed test 'Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console/Basic.pm"'
#   at /Users/rbo/Perl/perls/perl-5.12.0/lib/site_perl/5.12.0/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console/Basic.pm":
# Private Member Data shouldn't be accessed directly at line 56, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 57, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 58, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 59, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 60, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
# Private Member Data shouldn't be accessed directly at line 61, column 26.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
ok 11 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Console/Client.pm"
ok 12 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Job/Method.pm"
not ok 13 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Worker/AttributeParser.pm"

#   Failed test 'Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Worker/AttributeParser.pm"'
#   at /Users/rbo/Perl/perls/perl-5.12.0/lib/site_perl/5.12.0/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Worker/AttributeParser.pm":
# Private Member Data shouldn't be accessed directly at line 88, column 9.  Accessing an objects data directly breaks encapsulation and should be avoided.  Example: $object->{ some_key }.  (Severity: 5)
ok 14 - Test::Perl::Critic for "/Volumes/Users/rbo/Development/Perl/Contribute/gearman-driver/xt/../lib/Gearman/Driver/Worker/Base.pm"
# Looks like you failed 5 tests of 14.
Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/14 subtests 

Test Summary Report
-------------------
xt/00-critic.t (Wstat: 1280 Tests: 14 Failed: 5)
  Failed tests:  1, 3-4, 10, 13
  Non-zero exit status: 5
Files=1, Tests=14, 10 wallclock secs ( 0.04 usr  0.01 sys +  7.39 cusr  0.16 csys =  7.60 CPU)
Result: FAIL