Skip to content

Instantly share code, notes, and snippets.

@rch850

rch850/push-f-pr.md

Last active August 29, 2015 14:02
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save rch850/6a73468d546cd8ad0211 to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save rch850/6a73468d546cd8ad0211 to your computer and use it in GitHub Desktop.
Download ZIP
push -f for merge requests, pros and cons.
Raw
push-f-pr.md

I like to do push -f of branch for merge request.

pros

  • can squash unnecessary 'fix bug' commit of following branch. 'fix bug' commit does not fix bug of original branch so it should be squashed.
    • 'add feature xxx'
    • 'fix bug of feature xxx'

cons

  • commits does not completely reflect your work
  • you will miss review comments per line
  • casual push -f might be danger for beginners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment