Created
September 18, 2019 15:24
-
-
Save robertgzr/cde76b82d4fe5fd916e079888ff1ef3b to your computer and use it in GitHub Desktop.
git diff d6fc6068c2e5d02e0d6ddcfb5ee5b8a73ddf23f8^..ad1ae964378edc3d61be6488ff5f973d7228edb4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/.travis.yml b/.travis.yml | |
index 469d466c76..1224c8288b 100644 | |
--- a/.travis.yml | |
+++ b/.travis.yml | |
@@ -1,26 +1,49 @@ | |
-language: go | |
-go: | |
- - 1.10.4 | |
- # - 1.11.4 | |
+language: minimal | |
-branches: | |
- except: | |
- - gh-pages | |
- - /^(.*)-build-[a-f0-9]{40}$/ | |
+# only run for non-push actions | |
+# with the exception of master and version branches | |
+if: type != push OR branch = master OR branch =~ /^\d{2}\.\d{2}-(.*)$/ | |
sudo: required | |
services: | |
- docker | |
+stages: | |
+ - test | |
+ - build | |
+ | |
before_install: | |
- docker version | |
-before_script: | |
- # prevent legacy integration tests from running to not exeed travis job time limit | |
- - sed -i -e '/run_test_integration_legacy_suites$/ s/^/#/' hack/make/.integration-test-helpers | |
+jobs: | |
+ include: | |
+ - stage: test | |
+ name: "Unit tests" | |
+ script: | |
+ - make test-unit | |
+ | |
+ - stage: test | |
+ name: "Integration tests" | |
+ before_script: | |
+ # prevent legacy integration tests from running to not exeed travis job time limit | |
+ - sed -i -e '/run_test_integration_legacy_suites$/ s/^/#/' hack/make/.integration-test-helpers | |
+ script: | |
+ - make test-integration | |
+ | |
+ - stage: build | |
+ name: "Build for x86_64" | |
+ script: | |
+ - docker build -f Dockerfile.build.x86_64 -t balena-engine-build-x86_64 . | |
+ - docker run --rm -v "$(pwd):/balena-engine" balena-engine-build-x86_64 ./build.sh | |
+ | |
+ - stage: build | |
+ name: "Build for armv7" | |
+ script: | |
+ - docker build -f Dockerfile.build.arm -t balena-engine-build-arm . | |
+ - travis_wait 30 docker run --rm -e GOARM=7 -v "$(pwd):/balena-engine" balena-engine-build-arm /bin/sh build.sh | |
-script: | |
- - make test-unit | |
- - make test-integration | |
- - docker build -f Dockerfile.build.x86_64 -t balena-engine-build-x86_64 . | |
- - docker run --rm -v "$(pwd):/balena-engine" balena-engine-build-x86_64 ./build.sh | |
+ - stage: build | |
+ name: "Build for aarch64" | |
+ script: | |
+ - docker build -f Dockerfile.build.aarch64 -t balena-engine-build-aarch64 . | |
+ - travis_wait 30 docker run --rm -v "$(pwd):/balena-engine" balena-engine-build-aarch64 /bin/sh build.sh | |
diff --git a/CHANGELOG.md b/CHANGELOG.md | |
index 9a3bc24ebd..62f796e72f 100644 | |
--- a/CHANGELOG.md | |
+++ b/CHANGELOG.md | |
@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file | |
automatically by Versionist. DO NOT EDIT THIS FILE MANUALLY! | |
This project adheres to [Semantic Versioning](http://semver.org/). | |
+# v17.13.2 | |
+## (2019-02-21) | |
+ | |
+* travis: Use the minimal machine [Robert Günzler] | |
+ | |
+# v17.13.1 | |
+## (2019-02-20) | |
+ | |
+* vendor: Update runc to include fix for CVE-2019-5736 [Robert Günzler] | |
+ | |
# v17.13.0 | |
## (2019-01-31) | |
diff --git a/VERSION b/VERSION | |
index 0619135adf..dc0d7af23a 100644 | |
--- a/VERSION | |
+++ b/VERSION | |
@@ -1 +1 @@ | |
-17.13.0 | |
\ No newline at end of file | |
+17.13.2 | |
\ No newline at end of file | |
diff --git a/vendor.conf b/vendor.conf | |
index fdff2b01f7..1365f31581 100644 | |
--- a/vendor.conf | |
+++ b/vendor.conf | |
@@ -63,7 +63,7 @@ github.com/pborman/uuid v1.0 | |
google.golang.org/grpc v1.3.0 | |
# When updating, also update RUNC_COMMIT in hack/dockerfile/binaries-commits accordingly | |
-github.com/opencontainers/runc 663abfe04156311a2683ae6f7e2e195dd81cd023 https://github.com/resin-os/balena-runc | |
+github.com/opencontainers/runc 10360463dbe755806e1ad0a1605a148b7cceb8fc https://github.com/resin-os/balena-runc | |
github.com/opencontainers/runtime-spec v1.0.0 | |
github.com/opencontainers/image-spec v1.0.0 | |
github.com/seccomp/libseccomp-golang 32f571b70023028bd57d9288c20efbcb237f3ce0 | |
diff --git a/vendor/github.com/opencontainers/runc/kill.go b/vendor/github.com/opencontainers/runc/kill.go | |
index dbc70f3cdd..77f31662ca 100644 | |
--- a/vendor/github.com/opencontainers/runc/kill.go | |
+++ b/vendor/github.com/opencontainers/runc/kill.go | |
@@ -61,13 +61,7 @@ signal to the init process of the "ubuntu01" container: | |
func parseSignal(rawSignal string) (syscall.Signal, error) { | |
s, err := strconv.Atoi(rawSignal) | |
if err == nil { | |
- sig := syscall.Signal(s) | |
- for _, msig := range signalMap { | |
- if sig == msig { | |
- return sig, nil | |
- } | |
- } | |
- return -1, fmt.Errorf("unknown signal %q", rawSignal) | |
+ return syscall.Signal(s), nil | |
} | |
signal, ok := signalMap[strings.TrimPrefix(strings.ToUpper(rawSignal), "SIG")] | |
if !ok { | |
diff --git a/vendor/github.com/opencontainers/runc/libcontainer/nsenter/cloned_binary.c b/vendor/github.com/opencontainers/runc/libcontainer/nsenter/cloned_binary.c | |
new file mode 100644 | |
index 0000000000..c8a42c23f7 | |
--- /dev/null | |
+++ b/vendor/github.com/opencontainers/runc/libcontainer/nsenter/cloned_binary.c | |
@@ -0,0 +1,268 @@ | |
+/* | |
+ * Copyright (C) 2019 Aleksa Sarai <[email protected]> | |
+ * Copyright (C) 2019 SUSE LLC | |
+ * | |
+ * Licensed under the Apache License, Version 2.0 (the "License"); | |
+ * you may not use this file except in compliance with the License. | |
+ * You may obtain a copy of the License at | |
+ * | |
+ * http://www.apache.org/licenses/LICENSE-2.0 | |
+ * | |
+ * Unless required by applicable law or agreed to in writing, software | |
+ * distributed under the License is distributed on an "AS IS" BASIS, | |
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
+ * See the License for the specific language governing permissions and | |
+ * limitations under the License. | |
+ */ | |
+ | |
+#define _GNU_SOURCE | |
+#include <unistd.h> | |
+#include <stdio.h> | |
+#include <stdlib.h> | |
+#include <stdbool.h> | |
+#include <string.h> | |
+#include <limits.h> | |
+#include <fcntl.h> | |
+#include <errno.h> | |
+ | |
+#include <sys/types.h> | |
+#include <sys/stat.h> | |
+#include <sys/vfs.h> | |
+#include <sys/mman.h> | |
+#include <sys/sendfile.h> | |
+#include <sys/syscall.h> | |
+ | |
+/* Use our own wrapper for memfd_create. */ | |
+#if !defined(SYS_memfd_create) && defined(__NR_memfd_create) | |
+# define SYS_memfd_create __NR_memfd_create | |
+#endif | |
+#ifdef SYS_memfd_create | |
+# define HAVE_MEMFD_CREATE | |
+/* memfd_create(2) flags -- copied from <linux/memfd.h>. */ | |
+# ifndef MFD_CLOEXEC | |
+# define MFD_CLOEXEC 0x0001U | |
+# define MFD_ALLOW_SEALING 0x0002U | |
+# endif | |
+int memfd_create(const char *name, unsigned int flags) | |
+{ | |
+ return syscall(SYS_memfd_create, name, flags); | |
+} | |
+#endif | |
+ | |
+/* This comes directly from <linux/fcntl.h>. */ | |
+#ifndef F_LINUX_SPECIFIC_BASE | |
+# define F_LINUX_SPECIFIC_BASE 1024 | |
+#endif | |
+#ifndef F_ADD_SEALS | |
+# define F_ADD_SEALS (F_LINUX_SPECIFIC_BASE + 9) | |
+# define F_GET_SEALS (F_LINUX_SPECIFIC_BASE + 10) | |
+#endif | |
+#ifndef F_SEAL_SEAL | |
+# define F_SEAL_SEAL 0x0001 /* prevent further seals from being set */ | |
+# define F_SEAL_SHRINK 0x0002 /* prevent file from shrinking */ | |
+# define F_SEAL_GROW 0x0004 /* prevent file from growing */ | |
+# define F_SEAL_WRITE 0x0008 /* prevent writes */ | |
+#endif | |
+ | |
+#define RUNC_SENDFILE_MAX 0x7FFFF000 /* sendfile(2) is limited to 2GB. */ | |
+#ifdef HAVE_MEMFD_CREATE | |
+# define RUNC_MEMFD_COMMENT "runc_cloned:/proc/self/exe" | |
+# define RUNC_MEMFD_SEALS \ | |
+ (F_SEAL_SEAL | F_SEAL_SHRINK | F_SEAL_GROW | F_SEAL_WRITE) | |
+#endif | |
+ | |
+static void *must_realloc(void *ptr, size_t size) | |
+{ | |
+ void *old = ptr; | |
+ do { | |
+ ptr = realloc(old, size); | |
+ } while(!ptr); | |
+ return ptr; | |
+} | |
+ | |
+/* | |
+ * Verify whether we are currently in a self-cloned program (namely, is | |
+ * /proc/self/exe a memfd). F_GET_SEALS will only succeed for memfds (or rather | |
+ * for shmem files), and we want to be sure it's actually sealed. | |
+ */ | |
+static int is_self_cloned(void) | |
+{ | |
+ int fd, ret, is_cloned = 0; | |
+ | |
+ fd = open("/proc/self/exe", O_RDONLY|O_CLOEXEC); | |
+ if (fd < 0) | |
+ return -ENOTRECOVERABLE; | |
+ | |
+#ifdef HAVE_MEMFD_CREATE | |
+ ret = fcntl(fd, F_GET_SEALS); | |
+ is_cloned = (ret == RUNC_MEMFD_SEALS); | |
+#else | |
+ struct stat statbuf = {0}; | |
+ ret = fstat(fd, &statbuf); | |
+ if (ret >= 0) | |
+ is_cloned = (statbuf.st_nlink == 0); | |
+#endif | |
+ close(fd); | |
+ return is_cloned; | |
+} | |
+ | |
+/* | |
+ * Basic wrapper around mmap(2) that gives you the file length so you can | |
+ * safely treat it as an ordinary buffer. Only gives you read access. | |
+ */ | |
+static char *read_file(char *path, size_t *length) | |
+{ | |
+ int fd; | |
+ char buf[4096], *copy = NULL; | |
+ | |
+ if (!length) | |
+ return NULL; | |
+ | |
+ fd = open(path, O_RDONLY | O_CLOEXEC); | |
+ if (fd < 0) | |
+ return NULL; | |
+ | |
+ *length = 0; | |
+ for (;;) { | |
+ int n; | |
+ | |
+ n = read(fd, buf, sizeof(buf)); | |
+ if (n < 0) | |
+ goto error; | |
+ if (!n) | |
+ break; | |
+ | |
+ copy = must_realloc(copy, (*length + n) * sizeof(*copy)); | |
+ memcpy(copy + *length, buf, n); | |
+ *length += n; | |
+ } | |
+ close(fd); | |
+ return copy; | |
+ | |
+error: | |
+ close(fd); | |
+ free(copy); | |
+ return NULL; | |
+} | |
+ | |
+/* | |
+ * A poor-man's version of "xargs -0". Basically parses a given block of | |
+ * NUL-delimited data, within the given length and adds a pointer to each entry | |
+ * to the array of pointers. | |
+ */ | |
+static int parse_xargs(char *data, int data_length, char ***output) | |
+{ | |
+ int num = 0; | |
+ char *cur = data; | |
+ | |
+ if (!data || *output != NULL) | |
+ return -1; | |
+ | |
+ while (cur < data + data_length) { | |
+ num++; | |
+ *output = must_realloc(*output, (num + 1) * sizeof(**output)); | |
+ (*output)[num - 1] = cur; | |
+ cur += strlen(cur) + 1; | |
+ } | |
+ (*output)[num] = NULL; | |
+ return num; | |
+} | |
+ | |
+/* | |
+ * "Parse" out argv and envp from /proc/self/cmdline and /proc/self/environ. | |
+ * This is necessary because we are running in a context where we don't have a | |
+ * main() that we can just get the arguments from. | |
+ */ | |
+static int fetchve(char ***argv, char ***envp) | |
+{ | |
+ char *cmdline = NULL, *environ = NULL; | |
+ size_t cmdline_size, environ_size; | |
+ | |
+ cmdline = read_file("/proc/self/cmdline", &cmdline_size); | |
+ if (!cmdline) | |
+ goto error; | |
+ environ = read_file("/proc/self/environ", &environ_size); | |
+ if (!environ) | |
+ goto error; | |
+ | |
+ if (parse_xargs(cmdline, cmdline_size, argv) <= 0) | |
+ goto error; | |
+ if (parse_xargs(environ, environ_size, envp) <= 0) | |
+ goto error; | |
+ | |
+ return 0; | |
+ | |
+error: | |
+ free(environ); | |
+ free(cmdline); | |
+ return -EINVAL; | |
+} | |
+ | |
+static int clone_binary(void) | |
+{ | |
+ int binfd, memfd; | |
+ ssize_t sent = 0; | |
+ | |
+#ifdef HAVE_MEMFD_CREATE | |
+ memfd = memfd_create(RUNC_MEMFD_COMMENT, MFD_CLOEXEC | MFD_ALLOW_SEALING); | |
+#else | |
+ memfd = open("/tmp", O_TMPFILE | O_EXCL | O_RDWR | O_CLOEXEC, 0711); | |
+#endif | |
+ if (memfd < 0) | |
+ return -ENOTRECOVERABLE; | |
+ | |
+ binfd = open("/proc/self/exe", O_RDONLY | O_CLOEXEC); | |
+ if (binfd < 0) | |
+ goto error; | |
+ | |
+ sent = sendfile(memfd, binfd, NULL, RUNC_SENDFILE_MAX); | |
+ close(binfd); | |
+ if (sent < 0) | |
+ goto error; | |
+ | |
+#ifdef HAVE_MEMFD_CREATE | |
+ int err = fcntl(memfd, F_ADD_SEALS, RUNC_MEMFD_SEALS); | |
+ if (err < 0) | |
+ goto error; | |
+#else | |
+ /* Need to re-open "memfd" as read-only to avoid execve(2) giving -EXTBUSY. */ | |
+ int newfd; | |
+ char *fdpath = NULL; | |
+ | |
+ if (asprintf(&fdpath, "/proc/self/fd/%d", memfd) < 0) | |
+ goto error; | |
+ newfd = open(fdpath, O_RDONLY | O_CLOEXEC); | |
+ free(fdpath); | |
+ if (newfd < 0) | |
+ goto error; | |
+ | |
+ close(memfd); | |
+ memfd = newfd; | |
+#endif | |
+ return memfd; | |
+ | |
+error: | |
+ close(memfd); | |
+ return -EIO; | |
+} | |
+ | |
+int ensure_cloned_binary(void) | |
+{ | |
+ int execfd; | |
+ char **argv = NULL, **envp = NULL; | |
+ | |
+ /* Check that we're not self-cloned, and if we are then bail. */ | |
+ int cloned = is_self_cloned(); | |
+ if (cloned > 0 || cloned == -ENOTRECOVERABLE) | |
+ return cloned; | |
+ | |
+ if (fetchve(&argv, &envp) < 0) | |
+ return -EINVAL; | |
+ | |
+ execfd = clone_binary(); | |
+ if (execfd < 0) | |
+ return -EIO; | |
+ | |
+ fexecve(execfd, argv, envp); | |
+ return -ENOEXEC; | |
+} | |
diff --git a/vendor/github.com/opencontainers/runc/libcontainer/nsenter/nsexec.c b/vendor/github.com/opencontainers/runc/libcontainer/nsenter/nsexec.c | |
index a6a107e6e6..4e1f1ef797 100644 | |
--- a/vendor/github.com/opencontainers/runc/libcontainer/nsenter/nsexec.c | |
+++ b/vendor/github.com/opencontainers/runc/libcontainer/nsenter/nsexec.c | |
@@ -528,6 +528,9 @@ void join_namespaces(char *nslist) | |
free(namespaces); | |
} | |
+/* Defined in cloned_binary.c. */ | |
+extern int ensure_cloned_binary(void); | |
+ | |
void nsexec(void) | |
{ | |
int pipenum; | |
@@ -543,6 +546,14 @@ void nsexec(void) | |
if (pipenum == -1) | |
return; | |
+ /* | |
+ * We need to re-exec if we are not in a cloned binary. This is necessary | |
+ * to ensure that containers won't be able to access the host binary | |
+ * through /proc/self/exe. See CVE-2019-5736. | |
+ */ | |
+ if (ensure_cloned_binary() < 0) | |
+ bail("could not ensure we are a cloned binary"); | |
+ | |
/* Parse all of the netlink configuration. */ | |
nl_parse(pipenum, &config); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment