-
-
Save robertmryan/0cb300bdbcd560cfa999b817e8f71999 to your computer and use it in GitHub Desktop.
func upload(files: [URL]) async throws -> Bool { | |
try await withThrowingTaskGroup(of: Bool.self) { group in | |
let session = try SSH(host: "xxx", port:"xxx") | |
let sftp = try session.openSftp() | |
for file in files { | |
group.addTask { | |
try await self.upload(file: file, with: sftp, session: session) | |
} | |
} | |
var count = 0 | |
for try await isSuccessful in group where isSuccessful { | |
count += 1 | |
} | |
return count == files.count | |
} | |
} |
@williamhqs – Now, regarding your remaining error, that would appear to stem from Shout’s failure to define SSH
or SFTP
as Sendable
. I can’t comment directly on that (as this is not a library that I’ve ever used), but given that it’s using a non-isolated class
(rather than an isolated one or an actor
), so that’s not promising. You might want to post an issue there. I confess that I don’t even know if it supports concurrent requests; glancing at the code, I don’t see any async
functions, so that is not promising, either.
But if you post an issue there, the author might be able to comment further. But prepare yourself for the possibility that simply can’t do that. Or you might have to create a separate session for each upload. I can’t comment without doing a lot more investigation (which I am am afraid that I can’t tackle right now as I’m currently quite busy).
@robertmryan That's already a great help for me, thank you for you time, have a good day! :)
@williamhqs
Regarding cancelation, consider:
That will cancel the whole group as soon as one fails.
However, if you do something like the following, the group will not cancel all of its tasks (though the error will be thrown):
That is what I was trying to convey when I said:
I didn’t know what you wanted to happen if one failed. Hopefully this helps clarify a few of the options.
Note, this presumes that your
upload
method even supports cancellation. My trivialbar
method does, but I can’t vouch for Shout.