Skip to content

Instantly share code, notes, and snippets.

@robhudson
Created April 20, 2015 17:30
Show Gist options
  • Save robhudson/6fbe2c1c72bec1f4fa51 to your computer and use it in GitHub Desktop.
Save robhudson/6fbe2c1c72bec1f4fa51 to your computer and use it in GitHub Desktop.
diff --git a/mkt/developers/tests/test_views.py b/mkt/developers/tests/test_views.py
index 2a45e8b..4236443 100644
--- a/mkt/developers/tests/test_views.py
+++ b/mkt/developers/tests/test_views.py
@@ -130,7 +130,7 @@ class TestAppDashboard(AppHubTest):
def test_public_app(self):
app = self.get_app()
doc = pq(self.client.get(self.url).content)
- item = doc('.item[data-addonid=%s]' % app.id)
+ item = doc('.item[data-addonid="%s"]' % app.id)
assert item.find('.price'), 'Expected price'
assert item.find('.item-details'), 'Expected item details'
assert not item.find('p.incomplete'), (
@@ -142,7 +142,7 @@ class TestAppDashboard(AppHubTest):
app = self.get_app()
app.update(status=mkt.STATUS_NULL)
doc = pq(self.client.get(self.url).content)
- assert doc('.item[data-addonid=%s] p.incomplete' % app.id), (
+ assert doc('.item[data-addonid="%s"] p.incomplete' % app.id), (
'Expected message about incompleted add-on')
eq_(doc('.more-actions-popup').length, 0)
@@ -151,7 +151,7 @@ class TestAppDashboard(AppHubTest):
version = Version.objects.create(addon=app, version='1.23')
app.update(_current_version=version, is_packaged=True)
doc = pq(self.client.get(self.url).content)
- eq_(doc('.item[data-addonid=%s] .item-current-version' % app.id
+ eq_(doc('.item[data-addonid="%s"] .item-current-version' % app.id
).text(),
'Packaged App Version: 1.23')
@@ -163,7 +163,7 @@ class TestAppDashboard(AppHubTest):
app.update(is_packaged=True)
Version.objects.create(addon=app, version='1.24')
doc = pq(self.client.get(self.url).content)
- eq_(doc('.item[data-addonid=%s] .item-latest-version' % app.id
+ eq_(doc('.item[data-addonid="%s"] .item-latest-version' % app.id
).text(),
'Pending Version: 1.24')
diff --git a/mkt/files/tests/test_views.py b/mkt/files/tests/test_views.py
index aef0d21..1319be4 100644
--- a/mkt/files/tests/test_views.py
+++ b/mkt/files/tests/test_views.py
@@ -170,7 +170,7 @@ class FilesBase(object):
self.file_viewer.extract()
res = self.client.get(self.file_url(not_binary))
doc = pq(res.content)
- eq_(doc('#commands td:last').text(), 'Back to review')
+ eq_(doc('#commands td')[-1].text_content(), 'Back to review')
def test_diff_redirect(self):
ids = self.files[0].id, self.files[1].id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment