Maru AntlR and solc AST for SWC-100

default_visibility_function.ts

const parser = require("solidity-parser-antlr");

import { IssuePointer } from "../maru/issue";
import { Plugin } from '../maru/plugin';
import SolFile from "../maru/sol_file";
import PluginConfig from "../maru/plugin_config";

let DefaultVisibilityFunction: Plugin;

DefaultVisibilityFunction = function (sol_file: SolFile, plugin_config: PluginConfig): IssuePointer[] {
  const issuePointers: IssuePointer[] = [];
  for (const f of sol_file.getContractFunctions()) {
    if (f.visibility.match(/default/)) {
      issuePointers.push(new IssuePointer(plugin_config.swcID, plugin_config.descriptionShort[0], f.location));
    }
  }
  return issuePointers;
};

exports.DefaultVisibilityFunction = DefaultVisibilityFunction;

FunctionDefinition.ts

// Rules involving the solc FunctionDefinition AST node
"use strict";

import { Issue, Severity } from '../issue';

function defaultVisibilityFunctionViolation(node: any, issues: Issue[]): boolean {
    if (node.attributes.visibility === "default") {
	     const mess = `Function ${node.attributes.name} visibility is not set and defaults to "public".`;
	     const issue = new Issue(node.src, "SWC-100", Severity.Warning, mess);
	     issues.push(issue);
	     return true;
    }
    return false;
}


// Register violation functions
exports.register = (): any[] => {
    return [defaultVisibilityFunctionViolation];
};