Created
February 17, 2016 15:42
-
-
Save rpl/cc5227509848ef7397ef to your computer and use it in GitHub Desktop.
mozreview UnicodeDecodeError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Are you sure you want to push to remote? (y/n): y | |
| pushing to ssh://reviewboard-hg.mozilla.org/gecko | |
| searching for changes | |
| remote: adding changesets | |
| remote: adding manifests | |
| remote: adding file changes | |
| remote: added 1 changesets with 1 changes to 1 files (+1 heads) | |
| remote: recorded push in pushlog | |
| submitting 1 changesets for review | |
| remote: ** unknown exception encountered, please report by visiting | |
| remote: ** https://mercurial-scm.org/wiki/BugTracker | |
| remote: ** Python 2.7.10 (default, May 28 2015, 09:58:55) [GCC 4.4.7 20120313 (Red Hat 4.4.7-11)] | |
| remote: ** Mercurial Distributed SCM (version 3.6.2) | |
| remote: ** Extensions loaded: pushlog, pushlog-feed, buglink, serverlog, rbserver | |
| remote: Traceback (most recent call last): | |
| remote: File "/repo/hg/venv_pash/bin/hg", line 43, in <module> | |
| remote: mercurial.dispatch.run() | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 54, in run | |
| remote: sys.exit((dispatch(request(sys.argv[1:])) or 0) & 255) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 116, in dispatch [104/46443] | |
| remote: ret = _runcatch(req) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 187, in _runcatch | |
| remote: return _dispatch(req) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 920, in _dispatch | |
| remote: cmdpats, cmdoptions) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 679, in runcommand | |
| remote: ret = _runcommand(ui, options, cmd, d) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 1051, in _runcommand | |
| remote: return checkargs() | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 1011, in checkargs | |
| remote: return cmdfunc() | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/dispatch.py", line 917, in <lambda> | |
| remote: d = lambda: util.checksignature(func)(ui, *args, **cmdoptions) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/util.py", line 801, in check | |
| remote: return func(*args, **kwargs) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/commands.py", line 5919, in serve | |
| remote: s.serve_forever() | |
| remote: File "/repo/hg/version-control-tools/hgext/serverlog/__init__.py", line 321, in serve_forever | |
| remote: return super(sshserverwrapped, self).serve_forever() | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/sshserver.py", line 103, in serve_forever | |
| remote: while self.serve_one(): | |
| remote: File "/repo/hg/version-control-tools/hgext/serverlog/__init__.py", line 350, in serve_one | |
| remote: return super(sshserverwrapped, self).serve_one() | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/sshserver.py", line 121, in serve_one | |
| remote: rsp = wireproto.dispatch(self.repo, self, cmd) | |
| remote: File "/repo/hg/version-control-tools/hgext/serverlog/__init__.py", line 342, in dispatch | |
| remote: return origdispatch(repo, proto, cmd) | |
| remote: File "/repo/hg/venv_pash/lib64/python2.7/site-packages/mercurial/wireproto.py", line 471, in dispatch | |
| remote: return func(repo, proto, *args) | |
| remote: File "/repo/hg/version-control-tools/hgext/reviewboard/hgrb/proto.py", line 186, in pushreviewwireprotocommand | |
| remote: res = _processpushreview(repo, req, ldap_username) | |
| remote: File "/repo/hg/version-control-tools/hgext/reviewboard/hgrb/proto.py", line 332, in _processpushreview | |
| remote: username=bzusername, apikey=bzapikey) | |
| remote: File "/repo/hg/version-control-tools/hgext/reviewboard/hgrb/proto.py", line 96, in post_reviews | |
| remote: return submit_reviews(*args, **kwargs) | |
| remote: File "/repo/hg/version-control-tools/hgext/reviewboard/hgrb/proto.py", line 125, in submit_reviews | |
| remote: commits=json.dumps(commits, encoding='utf-8')) | |
| remote: File "/usr/lib64/python2.7/json/__init__.py", line 243, in dumps | |
| remote: return _default_encoder.encode(obj) | |
| remote: File "/usr/lib64/python2.7/json/encoder.py", line 207, in encode | |
| remote: chunks = self.iterencode(o, _one_shot=True) | |
| remote: File "/usr/lib64/python2.7/json/encoder.py", line 270, in iterencode | |
| remote: return _iterencode(o, 0) | |
| remote: UnicodeDecodeError: 'utf8' codec can't decode byte 0xff in position 584: invalid start byte | |
| abort: unexpected response: empty string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # HG changeset patch | |
| # User Luca Greco <lgreco@mozilla.com> | |
| # Date 1455721035 -3600 | |
| # Wed Feb 17 15:57:15 2016 +0100 | |
| # Node ID 9010c3a60525d7b4ad74ad4f5c670f9dcd233234 | |
| # Parent 5d8b06b5b67e5422e6168fcfaa2ed4fac58b2640 | |
| Bug 1248982 - Fix spelling error in nsOSHelperAppService.mm inline comments. r?jdm | |
| MozReview-Commit-ID: 8QiITYlDd6o | |
| diff --git a/uriloader/exthandler/mac/nsOSHelperAppService.mm b/uriloader/exthandler/mac/nsOSHelperAppService.mm | |
| --- a/uriloader/exthandler/mac/nsOSHelperAppService.mm | |
| +++ b/uriloader/exthandler/mac/nsOSHelperAppService.mm | |
| @@ -324,17 +324,17 @@ nsOSHelperAppService::GetMIMEInfoFromOS( | |
| FSRef typeAppFSRef; | |
| FSRef extAppFSRef; | |
| CFStringRef cfMIMEType = NULL; | |
| if (!aMIMEType.IsEmpty()) { | |
| CFURLRef appURL = NULL; | |
| // CFStringCreateWithCString() can fail even if we're not out of memory -- | |
| - // for example if the 'cStr' parameter is something very wierd (like "ÿÿ~" | |
| + // for example if the 'cStr' parameter is something very weird (like "ÿÿ~" | |
| // aka "\xFF\xFF~"), or possibly if it can't be interpreted as using what's | |
| // specified in the 'encoding' parameter. See bug 548719. | |
| cfMIMEType = ::CFStringCreateWithCString(NULL, flatType.get(), | |
| kCFStringEncodingUTF8); | |
| if (cfMIMEType) { | |
| err = ::LSCopyApplicationForMIMEType(cfMIMEType, kLSRolesAll, &appURL); | |
| if ((err == noErr) && appURL && ::CFURLGetFSRef(appURL, &typeAppFSRef)) { | |
| haveAppForType = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment