Created
July 26, 2009 18:27
-
-
Save ry/155877 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Answer to http://github.com/ry/http-parser/issues/#issue/1 | |
// UNTESTED | |
struct line { | |
char *field; | |
size_t field_len; | |
char *value; | |
size_t value_len; | |
}; | |
#define CURRENT_LINE (&header[nlines-1]) | |
#define MAX_HEADER_LINES 2000 | |
static struct line header[MAX_HEADER_LINES]; | |
static int nlines = 0; | |
static int last_was_value = 0; | |
void | |
on_header_field (http_parser *_, const char *at, size_t len) | |
{ | |
if (last_was_value) { | |
nlines++; | |
if (nlines == MAX_HEADER_LINES) ;// error! | |
CURRENT_LINE->value = NULL; | |
CURRENT_LINE->value_len = 0; | |
CURRENT_LINE->field_len = len; | |
CURRENT_LINE->field = malloc(len+1); | |
strncpy(CURRENT_LINE->field, at, len); | |
} else { | |
assert(CURRENT_LINE->value == NULL); | |
assert(CURRENT_LINE->value_len == 0); | |
CURRENT_LINE->field_len += len; | |
CURRENT_LINE->field = realloc(CURRENT_LINE->field, | |
CURRENT_LINE->field_len+1); | |
strncat(CURRENT_LINE->field, at, len); | |
} | |
CURRENT_LINE->field[CURRENT_LINE->field_len] = '\0'; | |
last_was_value = 0; | |
} | |
void | |
on_header_value (http_parser *_, const char *at, size_t len) | |
{ | |
if (!last_was_value) { | |
CURRENT_LINE->value_len = len; | |
CURRENT_LINE->value = malloc(len+1); | |
strncpy(CURRENT_LINE->value, at, len); | |
} else { | |
CURRENT_LINE->value_len += len; | |
CURRENT_LINE->value = realloc(CURRENT_LINE->value, | |
CURRENT_LINE->value_len+1); | |
strncat(CURRENT_LINE->value, at, len); | |
} | |
CURRENT_LINE->value[CURRENT_LINE->value_len] = '\0'; | |
last_was_value = 1; | |
} |
Thanks for this
line 38 and 57 may have bug, if field or value == NULL, realloc will not init memories, strncat will let result string start with garbeges?
Awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Good!