Padawan to Jedi: Improve with: Tell don't ask / magic number removal / abstraction

padawan-to-jedi-droid-height.md

class Ship
{
  function droidWillFitInCockpit() : Boolean
  {
    var droid:Droid = getCurrentDroid()
    var droidHeight:Integer = 0;
    if(this.droid.name == "C-3PO")
    {
      droidHeight = 167
    }
    elseif(this.droid.name == "r2d2")
    {
      droidHeight = 109
    }
    return (droidHeight < 130)
  }
}

class Droid
{
  function Droid(name:String, height:Integer)
  {
    this.name = name;
    this.height = height;
  }
}

class Ship
{
  function droidWillFitInCockpit() : Boolean
  {
    var droid:Droid = getCurrentDroid()
    return droid.getHeight() < this.cockpitSize
}

class Droid
{
  function Droid(name:String, height:Integer)
  {
    this.name = name;
    this.height = height;
  }

  function getHeight(){
    return this.height
  }

}

Much better - assuming that the ship object has been instantiated with a cockpit size / there is a setter for this .. then the droid doesn't need to care about that - nor does the ship care about the droids name or have to set the droids height.