Skip to content

Instantly share code, notes, and snippets.

@s-espinosa

s-espinosa/commits_and_the_people_who_love_them.md

Created July 20, 2016 23:22
Show Gist options
  • Save s-espinosa/0e5c0f7c88c443c50a41809f6c91a943 to your computer and use it in GitHub Desktop.
Save s-espinosa/0e5c0f7c88c443c50a41809f6c91a943 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
commits_and_the_people_who_love_them.md

Commits and the People Who Love Them

Background

  • Working on a React app with existing code
  • Screenshot
  • Description
  • Invitation to mentors and back-end team to comment

Our First Commit

  • Deciding what to tackle
  • Feature added
  • Code Changed
  • Initial PR

Response

  • Opinions!
  • About the code we changed
  • About code we didn't change
  • With no opinion on one of our questions
  • How we handled them and our reasoning
    • Testing
    • Adjustments
    • New Issues

Other PRs and communication

  • PM to PM
  • Questions about code I don't know yet
  • Not wanting to hold anything up
  • How to keep everyone involved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment