Skip to content

Instantly share code, notes, and snippets.

@sag1v
Last active October 25, 2019 20:44
Show Gist options
  • Save sag1v/8fae47c022a4453236cd418efe1ba167 to your computer and use it in GitHub Desktop.
Save sag1v/8fae47c022a4453236cd418efe1ba167 to your computer and use it in GitHub Desktop.
Markdium-React state update on an unmounted component
function Pets() {
const [pets, dispatch] = useReducer(petsReducer, initialState);
const onChange = ({ target }) => {
dispatch({ type: "PET_SELECTED", payload: target.value });
};
useEffect(() => {
let mounted = true;
if (pets.selectedPet) {
dispatch({ type: "FETCH_PET" });
getPet(pets.selectedPet).then(data => {
if(mounted){
dispatch({ type: "FETCH_PET_SUCCESS", payload: data });
}
});
} else {
dispatch({ type: "RESET" });
}
return () => mounted = false;
}, [pets.selectedPet]);
return (
<div>
<select value={pets.selectedPet} onChange={onChange}>
<option value="">Select a pet</option>
<option value="cats">Cats</option>
<option value="dogs">Dogs</option>
</select>
{pets.loading && <div>Loading...</div>}
{pets.petData && <Pet {...pets.petData} />}
</div>
);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment