Last active
October 25, 2019 20:45
-
-
Save sag1v/a7b778c5470c4ce1710914413f8ea149 to your computer and use it in GitHub Desktop.
Markdium-React state update on an unmounted component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function Pets() { | |
| const [pets, dispatch] = useReducer(petsReducer, initialState); | |
| const isMountedRef = useRef(null); | |
| const onChange = ({ target }) => { | |
| dispatch({ type: "PET_SELECTED", payload: target.value }); | |
| }; | |
| useEffect(() => { | |
| isMountedRef.current = true; | |
| if (pets.selectedPet) { | |
| dispatch({ type: "FETCH_PET" }); | |
| getPet(pets.selectedPet).then(data => { | |
| if(isMountedRef.current){ | |
| dispatch({ type: "FETCH_PET_SUCCESS", payload: data }); | |
| } | |
| }); | |
| } else { | |
| dispatch({ type: "RESET" }); | |
| } | |
| return () => isMountedRef.current = false; | |
| }, [pets.selectedPet]); | |
| useEffect(() => { | |
| // we can access isMountedRef.current here as well | |
| }) | |
| return ( | |
| <div> | |
| <select value={pets.selectedPet} onChange={onChange}> | |
| <option value="">Select a pet</option> | |
| <option value="cats">Cats</option> | |
| <option value="dogs">Dogs</option> | |
| </select> | |
| {pets.loading && <div>Loading...</div>} | |
| {pets.petData && <Pet {...pets.petData} />} | |
| </div> | |
| ); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment