Skip to content

Instantly share code, notes, and snippets.

@saurabh2590
Last active May 17, 2017 08:52
Show Gist options
  • Save saurabh2590/684fef058c804267dae2483ef9e6ba16 to your computer and use it in GitHub Desktop.
Save saurabh2590/684fef058c804267dae2483ef9e6ba16 to your computer and use it in GitHub Desktop.
  1. Certain namespace and naming was repeated and hence proposal for folder structure:
  • Every ts(x) file have it's sibling as .spec.ts(x) file.
  • gizmos
    • fraction-pie
      • renderer
        • styles.scss
        • internal files such as index etc.
        • sub-renderers
      • editor
        • styles.scss
        • internal files such as index etc.
        • sub-editors
      • toolpad
        • styles.scss
        • internal files such as index etc.
        • sub-components
      • reducers(.ts) : flexible to have folder or file depending on the complexity
        • sub-reducers + root reducer
        • saga as async and streaming reducers
      • actions(.ts) : flexible to have folder or file depending on the complexity
        • collection of all action functions
      • constants(.ts): flexible to have folder or file depending on the complexity
        • all constants used in this scope.
      • README.md
      • index.ts : root file which adds itself to the gizmo map
    • polymorphic-gizmo
      • gizmo-map
    • Rendering libraries
  • testplayer: naming?
  • UI components: style guide components
    • style guide player/presenter: Just a config inside.
  • tests
    • integration_tests: Integration top level tests to make sure everything works together.
    • e2e_tests : Integration top level tests to make sure everything works together in presentation layer cross platform.
    • image_tests: Presentation layer tests & variations cross platform
  1. How and where we would consider runtime inputs from the application ? Such as device sizes, device capabilities, browser types? Some global props or component which could be assumed to have such things.

  2. Discuss about units using px or rem, for scaling up certain elements or the complete screens?

  3. Separate stories to be handled.

    4.1 High level testing story: http://trac.bm.loc/ticket/41725

    • image tests tests cross platform.
    • end-2-end tests cross platform.

    4.2 High level packaging pipeline. : http://trac.bm.loc/ticket/41770

    • web application ?
    • desktop application ?
    • android app?
    • iOS app?
    • Should consider dev & prod environment depending on app/repo in question.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment