Skip to content

Instantly share code, notes, and snippets.

@scampi
Last active June 8, 2016 23:52
Show Gist options
  • Select an option

  • Save scampi/30b8143c40179cdc07cbca1562ea59b3 to your computer and use it in GitHub Desktop.

Select an option

Save scampi/30b8143c40179cdc07cbca1562ea59b3 to your computer and use it in GitHub Desktop.

elastic/kibana#5981

  • meta fields support ?
  • @Bargs: I think it should not, since excluding a field is only for preventing huge fields to be loaded
  • documentation. Mention where the filtering happens, e.g., in the search table
  • test for filtering
  • in the dashboard
  • in discover
  • when adding a visualization
    • @Bargs: it is possible to create, e.g., a data table, with a term agg on an excluded field. OK ?
  • remove disable filter bar from the Field filters tab in the Settings page
  • typos
  • filter scripted fields ?
  • @Bargs: I think this should not be possible
  • sync field filters and field exclusion in control
  • @Bargs: should the exclusion checkbox in the field controls be removed ? ATM it doesn't work together with the "field filters". I think it is OK to remove it since the wildcard field filters are probably enough, and we can see the list of excluded fields too. See http://imgur.com/a/cZLgw
@scampi
Copy link
Author

scampi commented Jun 8, 2016

If the filter doesn't work for visualizations though, how does filtering work on dashboards? Does it just filter saved searches?

Yes, you are correct. I tested that when I create a visualization based on a saved search, I have the following:

  • excluded fields are not available (not in the JSON nor the Table view for a document)
  • if the visualization was created before excluding a field, you would see - as field's value.

It seems like that checkbox was added with this PR as well?

That checkbox was proposed by spalger early on the PR. But I think the logic was changed over time, given the series of commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment