Research for https://issues.redhat.com/browse/WFLY-20754

gistfile1.txt

Application improvements using transactions that are marked STATUS_MARKED_ROLLBACK in that the application was actually using a transaction but application was treated as if didn't have an active transaction:

1. TransactionScopedEntityManager.isInTx()  (org.jboss.as.jpa.container) calls to TransactionUtil.isInTx(TransactionManager)  (org.jboss.as.jpa.transaction)
AbstractEntityManager.detachQueryNonTxInvocation(EntityManager, Query)  (org.jboss.as.jpa.container)
 !this.isInTx() check so we changed from if ! (tx.getStatus() == Status.STATUS_ACTIVE) to if ! (tx.getStatus() == Status.STATUS_ACTIVE || tx.getStatus() == Status.STATUS_MARKED_ROLLBACK)
 I think that this change is more correct for the STATUS_MARKED_ROLLBACK case.
 // used by TransactionScopedEntityManager to detach entities loaded by a query in a non-Jakarta Transactions invocation.
 Previously if transaction is STATUS_MARKED_ROLLBACK we would of treated that as non-active transaction and we would of cleared persistence context after query.getResultList() returns.
 IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)
 
2. AbstractEntityManager.detachStoredProcedureQueryNonTxInvocation(EntityManager, StoredProcedureQuery)  (org.jboss.as.jpa.container)
 same as above.
 IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)

3. AbstractEntityManager.detachNonTxInvocation(EntityManager)  (org.jboss.as.jpa.container)
 same as above, previously if transaction is STATUS_MARKED_ROLLBACK we would of treated that as non-active transaction and we would of cleared persistence context after invocation returns;
 IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)

4. AbstractEntityManager.detachTypedQueryNonTxInvocation(EntityManager, TypedQuery<T>)  (org.jboss.as.jpa.container)
 same as above, previously if transaction is STATUS_MARKED_ROLLBACK we would of treated that as non-active transaction and we would of cleared persistence context after invocation returns;
 IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)

5. AbstractEntityManager.transactionIsRequired()  (org.jboss.as.jpa.container) this throws new TransactionRequiredException("tranasaction required exception") if !isInTx() this code covers the calls from below callers
Previous to the change, if transaction is STATUS_MARKED_ROLLBACK that would of thrown the exception since that is not Status.STATUS_ACTIVE.  So the code change looks right for these callers.
  AbstractEntityManager.refresh(Object, LockModeType, Map<String, Object>)  (org.jboss.as.jpa.container)
  AbstractEntityManager.persist(Object)  (org.jboss.as.jpa.container)
  AbstractEntityManager.merge(T)  (org.jboss.as.jpa.container)
  AbstractEntityManager.refresh(Object)  (org.jboss.as.jpa.container)
  AbstractEntityManager.refresh(Object, LockModeType)  (org.jboss.as.jpa.container)
  AbstractEntityManager.refresh(Object, Map<String, Object>)  (org.jboss.as.jpa.container)
  AbstractEntityManager.remove(Object)  (org.jboss.as.jpa.container)
  IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)

6. ExtendedEntityManager.internalAssociateWithJtaTx()  (org.jboss.as.jpa.container)  calls to TransactionUtil.isInTx(TransactionManager)  (org.jboss.as.jpa.transaction)
   Previously when the below callers associate Extended persistence context with active transaction they would of not done the XPC association (and error checking) if thread transaction is STATUS_MARKED_ROLLBACK.
 SFSBCallStack.pushCall(Map<String, ExtendedEntityManager>)  (org.jboss.as.jpa.container)
 ExtendedEntityManager.getEntityManager()  (org.jboss.as.jpa.container)
 JPAUserTransactionListener.userTransactionStarted()  (org.jboss.as.jpa.container)
 IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)


7. TransactionScopedEntityManager.getEntityManager()  (org.jboss.as.jpa.container) calls to TransactionUtil.isInTx(TransactionManager)  (org.jboss.as.jpa.transaction)
   Previously when the below callers have active transaction they would not handle transaction is STATUS_MARKED_ROLLBACK correctly (they would treat as non-tx).
AbstractEntityManager.persist(Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.find(Class<T>, Object, LockModeType, Map<String, Object>)  (org.jboss.as.jpa.container)
AbstractEntityManager.contains(Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.unwrap(Class<T>)  (org.jboss.as.jpa.container)
AbstractEntityManager.find(Class<T>, Object, LockModeType)  (org.jboss.as.jpa.container)
AbstractEntityManager.joinTransaction()  (org.jboss.as.jpa.container)
AbstractEntityManager.detach(Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.createQuery(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.getTransaction()  (org.jboss.as.jpa.container)
AbstractEntityManager.getProperties()  (org.jboss.as.jpa.container)
AbstractEntityManager.createStoredProcedureQuery(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.setProperty(String, Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.createNativeQuery(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.createQuery(CriteriaQuery<T>)  (org.jboss.as.jpa.container)
AbstractEntityManager.setFlushMode(FlushModeType)  (org.jboss.as.jpa.container)
AbstractEntityManager.createStoredProcedureQuery(String, Class...)  (org.jboss.as.jpa.container)
AbstractEntityManager.flush()  (org.jboss.as.jpa.container)
AbstractEntityManager.remove(Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.getEntityGraphs(Class<T>)  (org.jboss.as.jpa.container)
AbstractEntityManager.getCriteriaBuilder()  (org.jboss.as.jpa.container)
AbstractEntityManager.getFlushMode()  (org.jboss.as.jpa.container)
AbstractEntityManager.find(Class<T>, Object)(2 usages)  (org.jboss.as.jpa.container)
AbstractEntityManager.createQuery(CriteriaUpdate)  (org.jboss.as.jpa.container)
AbstractEntityManager.refresh(Object, LockModeType, Map<String, Object>)  (org.jboss.as.jpa.container)
AbstractEntityManager.getReference(Class<T>, Object)(2 usages)  (org.jboss.as.jpa.container)
AbstractEntityManager.getMetamodel()  (org.jboss.as.jpa.container)
AbstractEntityManager.isJoinedToTransaction()  (org.jboss.as.jpa.container)
AbstractEntityManager.createNamedStoredProcedureQuery(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.createNamedQuery(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.lock(Object, LockModeType, Map<String, Object>)  (org.jboss.as.jpa.container)
AbstractEntityManager.merge(T)  (org.jboss.as.jpa.container)
AbstractEntityManager.createEntityGraph(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.lock(Object, LockModeType)  (org.jboss.as.jpa.container)
AbstractEntityManager.refresh(Object, Map<String, Object>)  (org.jboss.as.jpa.container)
AbstractEntityManager.find(Class<T>, Object, Map<String, Object>)  (org.jboss.as.jpa.container)
AbstractEntityManager.clear()  (org.jboss.as.jpa.container)
AbstractEntityManager.createNativeQuery(String, String)  (org.jboss.as.jpa.container)
AbstractEntityManager.createQuery(CriteriaDelete)  (org.jboss.as.jpa.container)
AbstractEntityManager.createStoredProcedureQuery(String, String...)  (org.jboss.as.jpa.container)
AbstractEntityManager.getLockMode(Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.createEntityGraph(Class<T>)  (org.jboss.as.jpa.container)
AbstractEntityManager.refresh(Object, LockModeType)  (org.jboss.as.jpa.container)
AbstractEntityManager.getEntityManagerFactory()  (org.jboss.as.jpa.container)
AbstractEntityManager.createNativeQuery(String, Class)  (org.jboss.as.jpa.container)
AbstractEntityManager.createNamedQuery(String, Class<T>)  (org.jboss.as.jpa.container)
AbstractEntityManager.getEntityGraph(String)  (org.jboss.as.jpa.container)
AbstractEntityManager.getDelegate()  (org.jboss.as.jpa.container)
AbstractEntityManager.close()  (org.jboss.as.jpa.container)
AbstractEntityManager.refresh(Object)  (org.jboss.as.jpa.container)
AbstractEntityManager.isOpen()  (org.jboss.as.jpa.container)
AbstractEntityManager.createQuery(String, Class<T>)  (org.jboss.as.jpa.container)
IMPACT: BUG FIXED (when STATUS_MARKED_ROLLBACK)