Created
September 12, 2013 21:41
-
-
Save secretrobotron/6544243 to your computer and use it in GitHub Desktop.
Prevent empty _events properties from causing an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -422,11 +422,16 @@ define('api/sketchfab-iframe',[ "vendors/q/q.min"], function( Q ) { | |
this._events[data.status] = undefined; | |
} | |
} else { | |
- if (this._events[data.status].resolve !== undefined) { | |
- this._events[data.status].resolve(data); | |
- if (clear) { | |
- this._events[data.status] = undefined; | |
+ // XXXsecretrobotron: Added an extra `if` layer to protect against unexpected empty `_events` properties. | |
+ if (this._events[data.status]) { | |
+ if (this._events[data.status].resolve !== undefined) { | |
+ this._events[data.status].resolve(data); | |
+ if (clear) { | |
+ this._events[data.status] = undefined; | |
+ } | |
} | |
+ } else { | |
+ console.warn('Unexpected event not handled: "' + data.status + '"'); | |
} | |
} | |
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment