Created
October 21, 2019 10:52
-
-
Save shadeslayer/9158fb1a3c8b516e9acc05c14d93e801 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int drm_dumb_set_label_ioctl(struct drm_device *dev, | |
void *data, struct drm_file *file_priv) | |
{ | |
char *label; | |
struct drm_dumb_set_label_object *args = data; | |
int ret = 0; | |
if (!dev->driver->label) | |
return -EOPNOTSUPP; | |
if (!args->len || !args->name) | |
label = NULL; | |
else | |
label = strndup_user(u64_to_user_ptr(args->name), args->len); | |
if (IS_ERR(label)) { | |
ret = PTR_ERR(label); | |
return ret; | |
} | |
ret = dev->driver->label(dev, file_priv, args->handle, label); | |
err: | |
kfree(label); | |
return ret; | |
} |
That sounds reasonable to me too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd rather have
as I consider args->len && !args->name a bug