Last active
January 10, 2020 08:59
-
-
Save silkyfray/def0b9e30f21e8952f95dd6838126a42 to your computer and use it in GitHub Desktop.
Example template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Ticket-XXX-Number - Fixing Things | |
| Delete any list items or questions that aren't relevant - if they're left unfilled it's assumed that | |
| they're relevant but your PR isn't finished yet. | |
| Write a short description of what the PR achieves. | |
| ## PR Declaration | |
| * [ ] I have implemented a feature, bug or improvement | |
| * [ ] Unit tests and linting are passing | |
| * [ ] I have written tests for the new logic I have included | |
| * [ ] I have written appropriate documentation | |
| * [ ] I have cross-browser tested my code | |
| * I have demoed to: | |
| * [ ] UX | |
| * [ ] QA | |
| * [ ] BA | |
| * [ ] Business | |
| ## NOTES TO QA (delete as appropriate, add anything if relevant) | |
| * This change requires cross browser testing | |
| * This change affects SEO | |
| ## Does this PR rely on changes in any other module (e.g. UiKit)? | |
| ## Did you encounter unexpected difficulty when doing this piece of work? What was it? Could it have been avoided? | |
| ## Did you come across any areas of the codebase that you felt were inconsistent or would benefit from a re-factor in any way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment