Skip to content

Instantly share code, notes, and snippets.

@simi

simi/ugly.rb

Created March 2, 2011 15:24
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save simi/851086 to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save simi/851086 to your computer and use it in GitHub Desktop.
Download ZIP
Don't like this
Raw
ugly.rb
attr_reader :loaded
def loaded?
loaded = @loaded ? true : false
@loaded = true
return loaded
end
@judofyr
Copy link
Copy Markdown

judofyr commented Mar 2, 2011

Why exactly does a method that ends with a question mark change the ivar? Seems confusing to me… Anyway, what about something like this:

def loaded?
  !!@loaded  # !! to cast it into boolean.
ensure
  @loaded = true
end

@simi
Copy link
Copy Markdown
Author

simi commented Mar 2, 2011

I know it is not good name. But I know how to name it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment