Skip to content

Instantly share code, notes, and snippets.

@simonihmig
Created May 19, 2017 18:23
Show Gist options
  • Save simonihmig/7c367c8b87176b6c05a63fdfc9969022 to your computer and use it in GitHub Desktop.
Save simonihmig/7c367c8b87176b6c05a63fdfc9969022 to your computer and use it in GitHub Desktop.
scroll-listener-test-failing
import Ember from 'ember';
const { computed } = Ember;
export default Ember.Component.extend({
classNames: ['my-component'],
classNameBindings: ['show'],
show: computed({
get() {
return false;
},
set(key, value) {
if (value) {
this.addScrollListener();
} else {
this.removeScrollListener();
}
return value;
}
}),
onScroll() {
console.log('scrolling...');
this.set('show', false);
},
_scrollElement: computed(function() {
return window;
}),
addScrollListener() {
this._listener = Ember.run.bind(this, this.onScroll);
this.get('_scrollElement').addEventListener('scroll', this._listener, false);
},
removeScrollListener() {
this.get('_scrollElement').removeEventListener('scroll', this._listener, false);
},
actions: {
addClass() {
this.set('show', true);
}
},
willDestroyElement() {
this._super(...arguments);
this.removeScrollListener();
}
});
import Ember from 'ember';
export default Ember.Controller.extend({
appName: 'Ember Twiddle'
});
import Ember from 'ember';
export default Ember.Controller.extend({
});
body {
margin: 12px 16px;
font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif;
font-size: 12pt;
height: 3000px;
}
.my-component.show {
background-color: red;
}
<h1>Welcome to {{appName}}</h1>
<br>
<br>
{{outlet}}
<br>
<br>
{{my-component}}
My component
<br>
<br>
<button {{action "addClass"}}>Add class</button>
import Ember from 'ember';
export default function destroyApp(application) {
Ember.run(application, 'destroy');
}
import Resolver from '../../resolver';
import config from '../../config/environment';
const resolver = Resolver.create();
resolver.namespace = {
modulePrefix: config.modulePrefix,
podModulePrefix: config.podModulePrefix
};
export default resolver;
import Ember from 'ember';
import Application from '../../app';
import config from '../../config/environment';
const { run } = Ember;
const assign = Ember.assign || Ember.merge;
export default function startApp(attrs) {
let application;
let attributes = assign({rootElement: "#test-root"}, config.APP);
attributes = assign(attributes, attrs); // use defaults, but you can override;
run(() => {
application = Application.create(attributes);
application.setupForTesting();
application.injectTestHelpers();
});
return application;
}
import { moduleForComponent, test } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile';
moduleForComponent('my-component', 'TODO: put something here', {
integration: true
});
test('it renders', function(assert) {
this.render(hbs`{{my-component}}`);
assert.equal(this.$().is(":visible"), true);
});
test('it should add class when we click on button', function(assert) {
this.render(hbs`{{my-component}}`);
assert.ok(this.$('div').hasClass('my-component'));
assert.notOk(this.$('div').hasClass('show'));
this.$('button').click();
assert.ok(this.$('div').hasClass('show'));
});
test('it should remove the class when we start scrolling', function(assert) {
this.set('element', document.getElementById('ember-testing-container'));
this.render(hbs`<div style="height: 3000px;">{{my-component _scrollElement=element}}</div>`);
this.$('button').click();
assert.ok(this.$('div').hasClass('show'));
this.get('element').scrollTop = 400;
assert.equal(this.get('element').scrollTop, 400)
let done = assert.async();
setTimeout(function() {
assert.notOk(this.$('div').hasClass('show'));
done()
}, 0);
});
import resolver from './helpers/resolver';
import {
setResolver
} from 'ember-qunit';
setResolver(resolver);
{
"version": "0.12.1",
"EmberENV": {
"FEATURES": {}
},
"options": {
"use_pods": false,
"enable-testing": true
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.3/jquery.js",
"ember": "2.12.0",
"ember-template-compiler": "2.12.0",
"ember-testing": "2.12.0"
},
"addons": {
"ember-data": "2.12.1"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment