Last active
August 29, 2015 14:11
-
-
Save simonster/b1b4cc2ad0daa8e20a99 to your computer and use it in GitHub Desktop.
missingness sum benchmark
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immutable CheapMulBool | |
x::Bool | |
end | |
immutable Negated{T} | |
x::T | |
end | |
immutable BitWrapper | |
x::Vector{Uint64} | |
end | |
Base.getindex(x::BitWrapper, i) = CheapMulBool(!Base.unsafe_bitgetindex(x.x, i)) | |
Base.getindex(x::Negated, i) = CheapMulBool(unsafe_load(convert(Ptr{Uint8}, pointer(x.x)), i) == 0) | |
*(x::CheapMulBool, y::Number) = ifelse(x.x, y, zero(y)) | |
function f(x, y) | |
z = zero(eltype(x)) | |
@simd for i = 1:length(x) | |
@inbounds z += y[i]*x[i] | |
end | |
z | |
end | |
x = randn(10000000) | |
ybool = rand(Bool, length(x)) | |
ybit = bitpack(ybool) | |
yfloat = convert(Vector{Float64}, !ybool) | |
f(x, Negated(ybool)) | |
f(x, BitWrapper(ybit.chunks)) | |
f(x, yfloat) | |
@time for i = 1:50 f(x, Negated(ybool)) end | |
@time for i = 1:50 f(x, BitWrapper(ybit.chunks)) end | |
@time for i = 1:50 f(x, yfloat) end |
So the moral seems to be that the BitArray
approach can potentially be made quite fast in the future. Any idea why you observe a slow down with LLVM SVN compared to 3.4 (or 3.5?) when not unrolling?
The comparison is to LLVM 3.3, which partially vectorizes the loop whereas LLVM SVN doesn't vectorize it at all. I can't explain why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
And for comparison, the NaN-based approach, again on LLVM SVN:
(This is basically the same as an ordinary sum.)