Last active
March 5, 2019 17:27
-
-
Save sloria/5895679 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class Point: | |
def __init__(self, x, y): | |
self.x, self.y = x, y | |
@classmethod | |
def polar(cls, r, theta): | |
return cls(r * cos(theta), | |
r * sin(theta)) | |
point = Point.polar(r=13, theta=22.6) |
(Looks like the gist comment doesn't want to preserve my spacing). Suggestion: Line up the r * sin(theta)
under r * cos(theta)
to conform to PEP 8.
The arguments for polar should be named (line 6) to match the call on line 10. Better yet, the call on line 10 should be changed to have positional arguments so that it matches the original constructor for Point
missed one underscore on the second line
Fixed. Thanks for the suggestions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
theta=22.6