Skip to content

Instantly share code, notes, and snippets.

@spiffxp
Last active December 2, 2018 03:10
Show Gist options
  • Save spiffxp/dfe52c0881645052ff037e317d9ad18b to your computer and use it in GitHub Desktop.
Save spiffxp/dfe52c0881645052ff037e317d9ad18b to your computer and use it in GitHub Desktop.
  • Q: does k8s-ci-robot remove do-not-merge/cherry-pick-not-approved on its own?

  • A: yes (eg: kubernetes/kubernetes#65959)

  • Q: are milestones required for cherry pick merges?

  • A: not with tide, eg: kubernetes/kubernetes#67150, kubernetes/kubernetes#67162

  • A: mungegithub doesn't comment about this requirement as far as I can tell so I don't know how folks tribally learned about it

  • Q: is cherrypick-candidate required for merge?

  • A: no

release-1.11 (@foxish)

merged by k8s-ci-robot
merged by k8s-merge-robot
cherry-pick-approved manually added
do-not-merge/cherry-pick-not-approved manually removed
cherrypick-candidate manually added
src PR had no cherrypick-candidate label
same as above but...
not actually a cherry pick
same as above except...
src PR had cherrypick-candidate label applied after merge
nothing was done with cherrypick-candidate label after cp merge

release-1.10 (@MaciekPytel)

merged by k8s-ci-robot
merged by k8s-merge-robot
cherry-pick-approved manually added
do-not-merge/cherry-pick-not-approved manually removed
src PR had no cherrypick-candidate label
not actually a cherry pick

release-1.9 (@mbohlool)

merged by k8s-ci-robot
merged by k8s-merge-robot
cherry-pick-approved manually added
do-not-merge/cherry-pick-not-approved manually removed
cherrypick-candidate manually added
src PR had no cherrypick-candidate label
same as above except...
src PR had cherrypick-candidate label applied after merge
nothing was done with cherrypick-candidate label after cp merge
same as above except...
not actually a cherry pick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment