Skip to content

Instantly share code, notes, and snippets.

@srobertson

srobertson/test_analysis_table.md

Created July 23, 2025 17:53
Show Gist options
  • Save srobertson/e3ee117d1039ee66cd300bbc8f332803 to your computer and use it in GitHub Desktop.
Save srobertson/e3ee117d1039ee66cd300bbc8f332803 to your computer and use it in GitHub Desktop.
Download ZIP
DayTracker Test Analysis - Detailed Recommendations for Issue #116
Raw
test_analysis_table.md

DayTracker Test Analysis - Detailed Recommendations

Summary Statistics

  • Total test functions analyzed: 234
  • Keep: 156 tests (67%)
  • Simplify: 19 tests (8%)
  • Merge: 29 tests (12%)
  • Remove: 30 tests (13%)

Detailed Test Analysis

File Test Function Core Purpose Recommendation Reasoning
test_cli.py (empty) Placeholder Remove Empty file, tests moved elsewhere
test_cli_entity_lifecycle.py
test_start_project_basic Test project creation via CLI Keep Essential lifecycle test
test_start_project_with_description Test project with description Merge Parameterize with basic test
test_start_hierarchical_project Test hierarchical projects Keep Unique functionality
test_end_project Test project removal Keep Essential lifecycle test
test_end_nonexistent_project Test error handling Keep Important error case
test_start_duplicate_project Test duplicate error Keep Important validation
test_add_person_basic Test person creation Keep Essential lifecycle test
test_add_person_with_description Test person with description Merge Parameterize with basic test
test_remove_person Test person removal Keep Essential lifecycle test
test_remove_nonexistent_person Test error handling Keep Important error case
test_add_duplicate_person Test duplicate error Keep Important validation
test_can_end_project_with_tasks Test project with tasks Keep Current behavior test
test_can_remove_person_with_tasks Test person with tasks Keep Current behavior test
test_json_output_for_entity_commands Test JSON output Keep JSON API consistency
test_project_name_formats Test name formats Keep Important validation
test_person_name_formats Test name formats Keep Important validation
test_cli_json.py
test_list_json_mode Test list JSON output Keep Core JSON functionality
test_tree_json_mode Test tree JSON output Keep Core JSON functionality
test_tree_inbox_only_scenario Test unassigned tasks Keep Important edge case
test_tree_empty_journal_shows_inbox Test empty journal Keep Important edge case
test_validate_json_mode_success Test validate JSON Keep Core JSON functionality
test_capture_json_mode Test capture JSON Keep Core JSON functionality
test_close_json_mode Test close JSON Keep Core JSON functionality
test_hash_json_mode Test hash JSON Keep Core JSON functionality
test_journals_json_mode Test journals JSON Keep MCP-only feature
test_file_not_found_json_mode Test error handling Keep Important error case
test_json_output_is_valid Test JSON validity Keep Important validation
test_cli_list_enhanced.py
test_list_tasks_default Test default behavior Keep Default behavior test
test_list_tasks_explicit Test explicit tasks Merge Merge with default test
test_list_projects Test project listing Keep Core entity listing
test_list_persons Test person listing Keep Core entity listing
test_list_invalid_entity_type Test invalid type Keep Important validation
test_list_tasks_json Test JSON output Merge Duplicate of cli_json tests
test_list_projects_json Test JSON output Merge Duplicate of cli_json tests
test_list_persons_json Test JSON output Merge Duplicate of cli_json tests
test_list_implicit_projects Test no projects message Keep Edge case behavior
test_list_implicit_persons Test no persons message Keep Edge case behavior
test_list_hierarchical_projects Test hierarchy counts Keep Important hierarchy test
test_list_integration_with_mcp Test MCP compatibility Keep Integration test
test_cli_operations.py
test_capture_with_description_only Test basic capture Keep Core operation test
test_capture_with_user_provided_id Test custom ID Keep ID handling test
test_capture_with_full_task_id Test full ID format Merge Parameterize with custom ID
test_capture_with_project Test project assignment Keep Relationship test
test_capture_with_invalid_project Test validation error Keep Important validation
test_capture_with_empty_description Test validation error Keep Important validation
test_capture_with_custom_timestamp Test timestamp handling Keep Timestamp test
test_close_with_hash_id Test close with #id Keep Core operation test
test_close_with_full_id Test close with Task:# Merge Parameterize with hash_id
test_close_with_memo Test close with memo Keep Memo functionality
test_close_with_invalid_id Test validation error Keep Important validation
test_close_with_custom_timestamp Test timestamp handling Keep Timestamp test
test_update_task_description Test basic update Keep Core operation test
test_update_project Test project update Keep Entity type handling
test_update_person Test person update Keep Entity type handling
test_update_with_mutations Test mutations Keep Important mutation test
test_update_with_description_and_mutations Test combined Keep Combination test
test_update_with_invalid_entity_id Test validation Keep Important validation
test_update_with_no_changes Test validation Keep Important validation
test_update_auto_generated_task_id Test auto ID Keep ID type test
test_hash_basic Test basic hash Keep Core operation test
test_hash_with_project Test with project Keep Relationship test
test_hash_with_project_name_only Test auto-prefix Keep Convenience feature
test_hash_with_empty_description Test validation Keep Important validation
test_hash_always_generates_auto_id Test ID generation Keep ID generation test
test_cli_query.py
test_query_command_basic Test basic GraphQL Keep Core query functionality
test_query_command_with_filter Test property filters Keep Filter test
test_query_command_with_relationships Test relationships Keep Relationship test
test_query_command_json_output Test JSON output Keep JSON API test
test_query_command_no_results Test no results Keep Edge case
test_query_command_parse_error Test syntax error Keep Error case
test_query_command_with_projection Test projection Keep Projection test
test_cli_update.py
test_update_single_value_fields Test field updates Keep Core functionality
test_update_with_description Test description update Keep Combined updates
test_add_project_assignments Test add relationships Keep Core functionality
test_remove_assignments Test remove relationships Keep Core functionality
test_set_replaces_all_values Test set operation Simplify Complex test
test_custom_fields Test custom fields Keep Current behavior
test_invalid_custom_field_format Test validation Keep Important validation
test_multiple_operations_in_one_command Test complex update Keep Integration test
test_update_project_entity Test project update Keep Non-task entities
test_update_person_entity Test person update Keep Non-task entities
test_validation_errors Test validation Keep Important validation
test_json_output_mode Test JSON output Keep JSON API test
test_task_dependencies Test dependencies Keep Dependency functionality
test_nonexistent_entity_update Test error case Keep Important error case
test_mcp_json.py
test_capture_success_json Test capture JSON Keep Core functionality
test_capture_duplicate_in_same_session Test duplicate error Keep Error validation
test_list_tasks_json Test list JSON Keep Core functionality
test_tree_json Test tree JSON Keep Core functionality
test_close_success_json Test close JSON Keep Core functionality
test_close_error_not_found Test error handling Keep Error validation
test_hash_preview_json Test hash JSON Keep Core functionality
test_compact_json Test compact (unimplemented) Remove Unimplemented feature
test_validate_success_json Test validate JSON Keep Core functionality
test_empty_journal Test empty journal Keep Edge case
test_all_tools_return_json Test all tools Simplify Could merge with individual
test_mcp_list_enhanced.py
test_list_default_tasks Test default behavior Keep Default behavior
test_list_explicit_tasks Test explicit tasks Merge Redundant
test_list_projects Test projects Keep Entity type
test_list_persons Test persons Keep Entity type
test_list_invalid_entity_type Test invalid type Keep Error validation
test_list_empty_projects Test empty projects Simplify Edge case test
test_list_empty_persons Test empty persons Simplify Edge case test
test_list_unassigned_tasks Test unassigned Keep Business logic
test_list_hierarchical_project_counts Test hierarchy Keep Complex logic
test_list_parity_with_cli Test parity Remove Duplicates cli_parity
test_mcp_cli_parity.py
test_list_tasks_parity Compare list output Keep E2E parity test
test_tree_parity Compare tree output Keep E2E parity test
test_validate_parity Compare validate Keep E2E parity test
test_hash_parity Compare hash Keep E2E parity test
test_capture_close_parity Test workflow Keep E2E workflow test
test_models.py
test_task_creation Test task creation Keep Core functionality
test_task_immutability Test frozen dataclass Remove Pattern well-established
test_task_replace Test replace method Keep Core functionality
test_task_defaults Test default values Merge Merge with creation
test_task_custom_fields Test custom fields Keep Important feature
test_task_equality Test equality Remove Standard dataclass behavior
test_task_hash Test hashability Remove Standard dataclass behavior
test_project_creation Test project creation Keep Core functionality
test_project_immutability Test frozen Remove Pattern well-established
test_project_replace Test replace Merge Merge with creation
test_person_creation Test person creation Keep Core functionality
test_person_immutability Test frozen Remove Pattern well-established
test_person_replace Test replace Merge Merge with creation
test_context_creation Test context creation Keep Core functionality
test_context_immutability Test frozen Remove Pattern well-established
test_context_defaults Test defaults Merge Merge with creation
test_label_creation Test label creation Keep Core functionality
test_label_immutability Test frozen Remove Pattern well-established
test_label_defaults Test defaults Merge Merge with creation
test_task_id_types Test ID types Keep Important type safety
test_project_id_type Test ID type Keep Important type safety
test_person_id_type Test ID type Keep Important type safety
test_context_id_type Test ID type Keep Important type safety
test_label_id_type Test ID type Keep Important type safety
test_id_type_distinction Test ID uniqueness Keep Type safety
test_add_entity_op Test operation Keep Core operation
test_update_entity_op Test operation Keep Core operation
test_remove_entity_op Test operation Keep Core operation
test_operation_immutability Test frozen Remove Pattern well-established
test_journal_compaction_ops Test compaction Keep Important feature
test_daytracker_state_empty Test empty state Keep Core functionality
test_daytracker_state_update_method Test state update Keep Core functionality
test_formatter.py
test_format_task_basic Test basic formatting Keep Core functionality
test_format_task_with_all_fields Test all fields Keep Comprehensive test
test_format_task_with_relationships Test relationships Keep Relationship formatting
test_format_task_list_empty Test empty list Keep Edge case
test_format_task_list_basic Test basic list Keep Core functionality
test_format_task_list_grouped_by_project Test grouping Keep Grouping logic
test_format_task_list_with_priorities Test priorities Keep Priority display
test_format_project_tree_empty Test empty tree Keep Edge case
test_format_project_tree_basic Test basic tree Keep Core functionality
test_format_project_tree_hierarchical Test hierarchy Keep Hierarchy display
test_format_compact_entry Test compact format Keep Compact display
test_format_daytracker_file Test file format Keep Complete formatting
test_formatter_basic.py
test_format_simple_task Test simple task Remove Duplicates main formatter
test_format_task_with_project Test with project Remove Duplicates main formatter
test_format_task_list Test task list Remove Duplicates main formatter
test_format_empty_list Test empty list Remove Duplicates main formatter
test_json_formatter.py
test_format_task_as_json Test task JSON Keep JSON formatting
test_format_task_list_as_json Test list JSON Keep JSON formatting
test_format_project_tree_as_json Test tree JSON Keep JSON formatting
test_format_validation_result_as_json Test validation JSON Keep JSON formatting
test_queries.py
test_get_projects_for_task Test task projects Keep Core query
test_get_tasks_for_project Test project tasks Keep Core query
test_get_assigned_persons Test assignees Keep Core query
test_get_tasks_for_person Test person tasks Keep Core query
test_get_parent_project Test hierarchy Keep Hierarchy query
test_get_child_projects Test hierarchy Keep Hierarchy query
test_get_all_descendant_projects Test descendants Keep Complex query
test_get_contexts_for_task Test contexts Keep Core query
test_get_tasks_for_context Test context tasks Keep Core query
test_get_labels_for_task Test labels Keep Core query
test_get_tasks_for_label Test label tasks Keep Core query
test_queries_with_empty_state Test empty state Keep Edge case
test_queries_with_no_relationships Test no relationships Keep Edge case
test_validation.py
test_validate_state_empty Test empty state Keep Core validation
test_validate_state_with_implicit_entities Test implicit Keep Implicit entity test
test_validate_missing_implicit_entities Test missing implicit Keep Error case
test_validate_task_references Test references Keep Reference validation
test_validate_circular_dependencies Test circular deps Keep Important validation
test_validate_missing_project Test missing project Keep Error case
test_validate_missing_person Test missing person Keep Error case
test_validate_complex_circular_dependency Test complex circular Keep Complex validation
test_validate_self_dependency Test self dependency Keep Edge case
test_validate_with_contexts Test contexts Keep Context validation
test_validate_with_labels Test labels Keep Label validation
test_integration.py
test_basic_file_parsing_and_state_building Test basic parsing Keep Core integration
test_complex_file_parsing_and_state_building Test complex parsing Keep Complex integration
test_incremental_task_evolution Test evolution Remove Skipped, unsupported
test_project_hierarchy_workflow Test hierarchy Keep Hierarchy integration
test_roundtrip_basic_content Test round-trip Remove Skipped, unsupported
test_roundtrip_preserves_task_identity Test identity Remove Skipped, deprecated
test_partial_parsing_recovery Test recovery Remove Empty test
test_circular_dependency_detection_integration Test circular Keep Validation integration
test_task_description_property Property test Simplify Move to unit tests
test_project_names_property Property test Simplify Move to unit tests
test_multiple_task_ids_property Property test Keep ID uniqueness
test_field_mutation_operators_property Property test Remove Skipped
test_large_file_processing_performance Performance test Remove Skipped, deprecated
test_task_count_scaling_property Scaling test Keep Performance property
test_basic_fixture_processing Test fixtures Keep Fixture integration
test_complex_fixture_processing Test fixtures Keep Complex fixtures
test_invalid_fixture_error_handling Test errors Simplify Focus on errors
test_e2e_cli.py
test_help_command Test help Keep Essential E2E
test_list_with_temp_journal Test list Keep Core E2E
test_list_json_format Test JSON Keep JSON E2E
test_validate_command Test validate Keep Validation E2E
test_tree_command Test tree Keep Tree E2E
test_capture_and_list_task Test lifecycle Keep Essential E2E
test_update_task_deadline Test deadline Keep Regression test
test_close_task Test close Keep Close E2E
test_project_lifecycle Test project Keep Project E2E
test_person_lifecycle Test person Keep Person E2E
test_personal_example_file Test example Keep Real data test
test_personal_example_tree Test tree Keep Real data test
test_personal_example_validate Test validate Keep Real data test
test_personal_example_json_output Test JSON Keep Real data test
test_invalid_journal_file Test invalid Keep Error E2E
test_nonexistent_file Test missing Keep Error E2E
test_invalid_command_arguments Test invalid args Keep Error E2E
test_deadline_datetime_formatting Test datetime Keep Regression test
test_complex_task_with_all_fields Test all fields Keep Comprehensive test
test_large_journal_performance Test performance Keep Performance E2E
test_comprehensive_scenarios.py
test_project_hierarchy_structure Test hierarchy Keep Complex scenario
test_task_lifecycle_and_relationships Test lifecycle Simplify Focus specific
test_multi_assignment_and_contexts Test multi-assign Simplify Limited by parser
test_custom_fields_and_metadata Test custom Remove Vague assertions
test_time_tracking_and_deadlines Test time Remove Only checks not None
test_entity_lifecycle_completion Test lifecycle Simplify More focus needed
test_load_operations Test LoadOp Keep Compaction test
test_forward_operations Test ForwardOp Keep State restoration
test_checkpoint_operation Test checkpoint Remove Only checks not None
test_post_compaction_operations Test post-compact Keep Compaction workflow
test_maintenance_project_structure Test maintenance Keep Specific structure
test_cross_journal_entity_references Test cross-journal Remove Empty test
test_journal_integrity_chain Test chain Remove Empty test
test_multiple_value_fields Test multi-value Keep Relationship handling
test_custom_field_handling Test custom Simplify Better assertions
test_field_validation_in_complex_scenario Test validation Remove Empty test
test_large_operation_count_performance Test performance Simplify Only checks not None
test_complex_relationship_queries Test queries Keep Query performance
test_hierarchical_project_queries Test hierarchy Keep Hierarchy queries
test_comprehensive_scenario_files_exist Test files Keep Data validation
test_examples.py
test_personal_example_loads Test personal Remove Skipped, unsupported
test_product_launch_example_loads Test product Remove Skipped, unsupported
test_example_task_ids_are_descriptive Test IDs Remove Skipped, unsupported
test_examples_demonstrate_features Test features Remove Skipped, unsupported
test_simple_duplicate_check.py
test_no_duplicate_relationships_in_journal Test duplicates Keep Core functionality
test_cli_commands_use_lowercase_fields Test lowercase Keep Field consistency
test_schema_has_no_field_aliases Test aliases Keep Schema validation
test_duplicate_integration.py
test_full_workflow_no_duplicates_cli_to_gql Test workflow Keep E2E integration
test_cli_update_doesnt_create_duplicates Test updates Keep Update validation
test_parser_output_compatibility Test parser Simplify Merge with schema
test_schema_field_validation Test schema Merge Duplicates other test
test_relationship_uniqueness.py
test_no_duplicate_relationships_on_task_creation Test creation Keep Core uniqueness
test_no_duplicate_relationships_on_update Test update Keep Update scenario
test_case_insensitive_field_names_resolve_to_same_relationship Test case Simplify Focus behavior
test_relationship_uniqueness_with_multiple_updates Test multiple Keep Complex scenario
test_journal_manager_relationship_uniqueness Test journal Keep Async interface
test_field_name_consistency.py
test_schema_uses_lowercase_field_names Test schema Keep Central validation
test_relationship_fields_are_lowercase Test fields Merge Combine with schema
test_cli_operations_use_lowercase Test CLI Keep CLI behavior
test_mcp_operations_use_lowercase Test MCP Keep MCP integration
test_set_relation_mutation.py
test_set_single_project Test single Keep Core mutation
test_set_multiple_assignees Test multiple Keep Multi-value
test_set_empty_relationships Test empty Keep Edge case
test_replace_with_same_values Test idempotent Keep Expected behavior
test_helpers.py
create_test_state Helper function Keep Useful utility

Key Recommendations

1. Remove Pattern Tests (30 tests)

  • All "test_*_immutability" tests - frozen dataclass pattern is well-established
  • All "test_equality" and "test_hash" tests - standard dataclass behavior
  • Empty/stub tests that just pass
  • Skipped tests using deprecated/unsupported features

2. Merge Related Tests (29 tests)

  • Combine basic and with-description tests using parameterization
  • Merge duplicate JSON tests across files
  • Combine related ID format tests
  • Merge field validation tests that check the same thing

3. Simplify Complex Tests (19 tests)

  • Tests that only check "state is not None"
  • Tests with vague assertions
  • Tests trying to verify too many things at once
  • Property tests that belong in unit tests

4. Keep Essential Tests (156 tests)

  • Core functionality tests
  • Error handling and validation
  • Edge cases and regression tests
  • E2E tests that verify user experience
  • Integration tests that verify component interaction

Expected Benefits

  1. Performance: ~30% faster test execution by removing redundant tests
  2. Clarity: Each test has single, clear purpose
  3. Maintainability: Less duplication means easier updates
  4. Coverage: Essential functionality still fully tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment