sscarduzio

description
Review PR changes for code quality, DRY violations, antipatterns, and improvement opportunities

PR Code Review

Perform a senior engineer-level code review focused on making changes easier and cleaner for the next developer.

Arguments

sscarduzio

import { useState, useEffect } from 'react';
import { Card, CardContent } from '../ui/card';
import { Textarea } from '../ui/textarea';
import Editor from "@monaco-editor/react";
import { Button } from '../ui/button';
import { X, Check, Copy } from 'lucide-react';
import { Algorithm, SUPPORTED_ALGORITHMS, KeyPair } from '../../types/activationKey';
import { decodeJWT, getJwtMetadata, signJWT, validateJWTSignature, ValidationResult } from '../../utils/activationKey';
import { ActivationKeyMetadataDisplay } from '../activationkey/ActivationKeyMetadata';
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '../ui/select';

sscarduzio

{"ts":"2022-04-15T13:01:08.780Z","msg":"logger initialized with name desktop"}
{"ts":"2022-04-15T13:01:08.821Z","msg":"on:ready","version":"2.0.46"}
{"ts":"2022-04-15T13:01:09.161Z","msg":"Core process status","alive":false}
{"ts":"2022-04-15T13:01:09.311Z","msg":"","cliBinPath":"/usr/local/bin/envkey","cliCurrent":"2.0.24","cliVersion":"2.0.24"}
{"ts":"2022-04-15T13:01:09.311Z","msg":"Starting core process daemon via CLI"}
{"ts":"2022-04-15T13:01:23.188Z","msg":"Successfully started core process"}
{"ts":"2022-04-15T13:01:23.188Z","msg":"core is running","currentAppVersion":"2.0.46"}
{"ts":"2022-04-15T13:01:23.188Z","msg":"Fetching root-device-key from OS credential store..."}
{"ts":"2022-04-15T13:01:23.188Z","msg":"CLI inside `pkg`"}
{"ts":"2022-04-15T13:01:23.189Z","msg":"loading keytar from __non_webpack_require__('keytar')"}

sscarduzio

/*
  SEE FIRST COMMENT FOR DESCRIPTION AND USAGE
*/
const Keycloak = require('keycloak-connect')
const express = require('express')
const session = require('express-session')
const app = express()

const LOGIN_PATH = '/login'
const LOGOUT_PATH = '/logout'

sscarduzio

Contribution License Agreement

Thank you for your interest in ReadonlyREST (“Product”), managed by Beshu Limited, a company duly established under the laws of United Kingdom, with registration number No. 10888034, and registered address at Office 32 13-21 Crawford Street, WH1 1PG, the owner the product (“We” or “Us”). We appreciate all the Contributions, made to our Product.

The purpose of this Contribution License Agreement (“CLA”, or “Agreement”) is to clarify the intellectual property rights granted with the Contribution to the Product from any person or entity. This CLA serves as a protection for a Contributor, as well as the protection of Us, our Product and its users.

This Agreement does not change your right to use your Contribution for the other purposes.

sscarduzio

const http = require('http')
const httpProxy = require('http-proxy')
const l = require('chalk')

// ---- Kibana
function filterHeaders(prefix, o) {
  var filtered = []
    for (k of Object.keys(o)) {
      if (k.indexOf(prefix) >= 0) {
        var partialObj = {}

sscarduzio

const http = require('http')
const httpProxy = require('http-proxy')
const l = require('chalk')

// ---- Kibana
function filterHeaders(prefix, o) {
  var filtered = []
    for (k of Object.keys(o)) {
      if (k.indexOf(prefix) >= 0) {
        var partialObj = {}

sscarduzio

# Usage: ./git-tag-delete-local-and-remote.sh 1.19
# will delete tags: "1.19.1" "1.19.2" "1.19.3" ...

for i in `git tag|grep $1` 
do 
  git push --delete origin "$i"
  git tag -d "$i" 
done

sscarduzio

version: '3.3'

services:

  elasticsearch:
    image: docker.elastic.co/elasticsearch/elasticsearch:7.5.2
    container_name: ror_elasticsearch
    hostname: ror_elasticsearch
    ports:
      - "9200:9200"

sscarduzio

version: '3.3'

services:

  elasticsearch:
    image: docker.elastic.co/elasticsearch/elasticsearch:7.5.2
    container_name: ror_elasticsearch
    hostname: ror_elasticsearch
    ports:
      - "9200:9200"