Skip to content

Instantly share code, notes, and snippets.

@sstratoti
Last active April 15, 2024 00:49
Show Gist options
  • Save sstratoti/8021c5a4ee8e34313c3f59ba20c4a83a to your computer and use it in GitHub Desktop.
Save sstratoti/8021c5a4ee8e34313c3f59ba20c4a83a to your computer and use it in GitHub Desktop.
iOS Subflow for HomeAssistant Companion notifications
@okets
Copy link

okets commented Mar 21, 2022

Hello @sstratoti,
I made some significant changes to your original sub-flow as I kept using it in more complex scenarios.
among the changes I made:

  1. Adding "No-sound" to the sounds list and changed "create service call" to send a silent message in such a case.
  2. Changed original "isCritical" Boolean to interruption levels list now you can choose between [Critical/Time Sensitive/Passive/Normal] instead of the old way that only supported [Normal/critical].
  3. Fixed multiple bugs around context storage, clearing messages and figuring out actions. now it can find the correct message when using tags in overrides, clears the correct messages etc.
  • the old code did not find the correct messages for actions if notificationOverride.tag was set.
  • the old code could only clear messages using the last service used, not the service used for the actual notification.
    ios notifications

You can find my updated sub-flow json in my fork:
https://gist.github.com/okets/c7baea968aab019a09c9d2c80df29d40

I will keep maintaining the link above as I make more changes or fixes.

@sstratoti
Copy link
Author

@okets and @henriklund - Thank you for your contributions to this code! I've mentioned this before - I really wanted to set up a github project for this so that we could all contribute code fixes and track issues.

I'm working on that now. I'm going to upload my latest code, and then grab the code from @okets gist and pull in your updates.

The repository will be found here: https://github.com/sstratoti/actionable-notifications-subflow-for-ios

I'm also updating the readme and am planning to add installation / update instructions.

@sstratoti
Copy link
Author

New repository is live!

@henriklund - would you like to be a contributor? Or could I take a peek at your changes to allow for +8 actions? It'll save me copy/paste time at least. :)

@sstratoti
Copy link
Author

I've added a wiki with details on installation, upgrading, and updated documentation. Please take a look and point out any spelling mistakes I've made. haha

@Automot360
Copy link

@sstratoti
Thank you!

@henriklund
Copy link

New repository is live!

@henriklund - would you like to be a contributor? Or could I take a peek at your changes to allow for +8 actions? It'll save me copy/paste time at least. :)

It is nothing fancy. Just repeat the properties for following until you reach action8Icon:

  • action4Title
  • action4ActivationMode
  • action4AuthenticationRequired
  • action4Destructive
  • action4Behavior
  • action4TextInputButtonTitle
  • action4TextInputPlaceHolder
  • action4Icon

In "Create service call" and "build message" change
[1,2,3,4]
to
[1,2,3,4,5,6,7,8]

@andystewart999
Copy link

You mean for the subflow module?

Yes, I built a subflow module last week, and I noticed the issue during my testings. After installing it on a different machine, it didn’t work as expected because the reference to the configuration node was not valid anymore. Unfortunately, there's currently no way to manage the link between nodes inside a subflow module and configuration nodes.

I reported this issue via Slack a few days ago, and there is a post about the same issue on the forum (link below).

https://discourse.nodered.org/t/packaging-a-subflow-as-a-module-missing-broker-configuration/55485

Hi - did the issue with configuration nodes ever get resolved, to your knowledge?

Cheers,
Andy

@bonanitech
Copy link

Hi - did the issue with configuration nodes ever get resolved, to your knowledge?

Some pull requests related to that were merged a couple of weeks ago. I haven't had the time to test if that fixed the issue.

@sstratoti
Copy link
Author

Have you tried the code in

https://github.com/sstratoti/actionable-notifications-subflow-for-ios

instead? I’ve made a few updates since this gist was created.

@andystewart999
Copy link

andystewart999 commented Apr 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment