Created
August 8, 2023 21:13
-
-
Save st3b1t/0c9875f9b4b3bf7e98f97cf41da43ad4 to your computer and use it in GitHub Desktop.
ACKs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concept ACK - Agree with the idea and overall direction, but haven't reviewed the code changes or tested them. | |
utACK (untested ACK) - Reviewed and agree with the code changes but haven't actually tested them. | |
Tested ACK - Reviewed the code changes and have verified the functionality or bug fix. | |
ACK - A loose ACK can be confusing. It's best to avoid them unless it's a documentation/comment only change in which case there is nothing to test/verify; therefore the tested/untested distinction is not there. | |
NACK - Disagree with the code changes/concept. Should be accompanied by an explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment