Created
December 21, 2010 19:07
-
-
Save stevenheidel/750390 to your computer and use it in GitHub Desktop.
Core team's discussion about base/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanda I'm slightly confused by Refinery having both base and core | |
Philip THAT IS STEVEN | |
:P | |
http://github.com/resolve/refinerycms/wiki… | |
I use caps when I don't mean to yell | |
Amanda also, I can never find the code that happens when you generate a new app, but that's probably because I'm forgetful | |
Steven Heidel: I see you are the source of my pain | |
Philip bin/refinerycms | |
core/lib/generators/ | |
Steven Heidel: I bet you hear that from all the girls | |
Amanda Philip: It's the bin/ one I always forget, I can find the core/lib/generators (eventually) | |
Steven H. whoa, I'm lost in the conversation | |
let me try again | |
Philip: more like source of my pleasure | |
but anyways | |
so base and core | |
4:45 PM | |
Steven H. what goes where? | |
Philip I assume base is the base | |
Steven H. core was too big | |
Philip and core is the core | |
What?! | |
Amanda to me, base and core appear to be synonyms | |
and Steven appears to agree, despite it being his idea. ;) | |
Philip I don't understand how they differ really | |
Steven H. I was thinking one should be generators, helpers, and so forth | |
Amanda from a vague inspection, core seems to be the serious internals of Refinery, and base seems to be some helper/additional files? | |
Steven H. and also loading the other engines | |
Amanda but important additional files ;) | |
Steven H. and core should be views, everything else that makes refinery tick | |
basically I was just thinking that some of our helpers, generators, and so forth could be helpful to other projects | |
4:50 PM | |
Steven H. so they should all be in one spot | |
4:50 PM | |
Amanda would they be useful to others individually, or only as a set? | |
Steven H. html_truncation_helper is very useful | |
core/lib is basically what I mean by base | |
but it already seems to be in one spot, hmmmm | |
Philip thanks for the complient on truncation helper | |
compliment* | |
Amanda I think a) if we're going to split them we need clearer names, and b) the more we split them the more places there are to look, so only do it if it's completely necessary | |
lib seems like a reasonable place to look for things that are more generally useful | |
Steven H. but if it makes things hard to find then don't do it | |
beat me to it | |
Amanda actually, could things that are shared just go in the base /lib rather than /core/lib? | |
just tossing out more theories ;) | |
Steven H. don't want to crowd the top-level namespace | |
Amanda: not a bad idea | |
lib/ is the first thing that gets included | |
4:55 PM | |
Philip uh | |
4:55 PM | |
Steven H. technically the root lib/ should do the whole defining of plugins too | |
that way then core is just a plugin and not some special magical thing that must be loaded first | |
Philip what is the root lib | |
are you using root for base | |
Steven H. (this idea is drawn from redcar of course) | |
no, the root of the app | |
Philip FYI core doesnt need to be loaded first | |
which app | |
Amanda Philip: on the version I have of Refinery, there's a lib folder | |
Philip refinery is a collection of engines | |
Steven H. https://github.com/resolve/refinerycms/tre… | |
Amanda that I just pulled from by_inclusion | |
5:00 PM | |
Steven H. maybe a good opinion to get would be that of the guy who did the restructuring | |
whose name escapes me | |
5:10 PM | |
Philip kml | |
5:15 PM | |
Steven H. Kamil | |
Philip yeah | |
his nickname is kml | |
he told me he's still hacking refinery apart | |
so we'll see | |
it's nice to get someone who isn't emotionally involved | |
;) | |
but doesn't have commit access | |
Steven H. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment