Focusing on descriptions

user_form_spec.rb

# Before - not clear what object / method do we test; 
# not clear what is the expected behavior; 
# context description is mixed with subject
describe "user form" do
  describe "saving with phone number" do
      it do
        allow(SmsGateway).to receive(:send_message)
        attributes = { phone_number: "0048 500 111 222" }

        form = UserForm.new(User.new, attributes)
        form.save

        expect(SmsGateway).to have_received(:send_message).
          with("0048 500 111 222", "Your account was created!")
      end
    end
end

# After - it is clear what method of which class we test, 
# what is the context and what is the expected behavior
describe UserForm do
  describe "#save" do
    context "when persisting new user" do
      context "when attributes contain valid phone number" do
        it "delivers SMS account creation notification to user created" do
          allow(SmsGateway).to receive(:send_message)
          attributes = { phone_number: "0048 500 111 222" }
          user = User.new

          form = UserForm.new(user, attributes)
          form.save

          expect(SmsGateway).to have_received(:send_message).
            with("0048 500 111 222", "Your account was created!")
        end
      end
    end
  end
end