Skip to content

Instantly share code, notes, and snippets.

@svasquezm
Last active August 21, 2020 19:05
Show Gist options
  • Save svasquezm/32e1f14e6867a0e37f6d28ade8dcc341 to your computer and use it in GitHub Desktop.
Save svasquezm/32e1f14e6867a0e37f6d28ade8dcc341 to your computer and use it in GitHub Desktop.

Proposed changes (mandatory)

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Jira ticket (if appropriate)

Checklist (mandatory)

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules (if appropriate)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered. Observations are valid to include here as well.

Preview (optional)

You can attach some images or gifs in order to show your team the changes.

Usage (optional)

If you are creating a new UI component or a new feature than requires to be explained, here you can write a brief explanation of how use this feature.

fun some(code: Here) {
  to(show: How).use(it)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment