Created
September 21, 2014 19:32
-
-
Save tdsmith/278e6bdaa5502bc5a5f3 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/Swift/QtUI/UserSearch/QtUserSearchWindow.cpp b/Swift/QtUI/UserSearch/QtUserSearchWindow.cpp | |
| index d69c626..2552d6d 100644 | |
| --- a/Swift/QtUI/UserSearch/QtUserSearchWindow.cpp | |
| +++ b/Swift/QtUI/UserSearch/QtUserSearchWindow.cpp | |
| @@ -221,7 +221,7 @@ void QtUserSearchWindow::setSearchFields(boost::shared_ptr<SearchPayload> fields | |
| fieldsPage_->setFormWidget(new QtFormWidget(fields->getForm(), fieldsPage_)); | |
| } else { | |
| fieldsPage_->setFormWidget(NULL); | |
| - bool enabled[8] = {fields->getNick(), fields->getNick(), fields->getFirst(), fields->getFirst(), fields->getLast(), fields->getLast(), fields->getEMail(), fields->getEMail()}; | |
| + bool enabled[8] = {!!fields->getNick(), !!fields->getNick(), !!fields->getFirst(), !!fields->getFirst(), !!fields->getLast(), !!fields->getLast(), !!fields->getEMail(), !!fields->getEMail()}; | |
| QWidget* legacySearchWidgets[8] = {fieldsPage_->nickInputLabel_, fieldsPage_->nickInput_, fieldsPage_->firstInputLabel_, fieldsPage_->firstInput_, fieldsPage_->lastInputLabel_, fieldsPage_->lastInput_, fieldsPage_->emailInputLabel_, fieldsPage_->emailInput_}; | |
| for (int i = 0; i < 8; i++) { | |
| legacySearchWidgets[i]->setVisible(enabled[i]); | |
| diff --git a/Swiften/Examples/NetworkTool/main.cpp b/Swiften/Examples/NetworkTool/main.cpp | |
| index 00c12d2..1473bf5 100644 | |
| --- a/Swiften/Examples/NetworkTool/main.cpp | |
| +++ b/Swiften/Examples/NetworkTool/main.cpp | |
| @@ -38,8 +38,8 @@ void handleGetForwardPortRequestResponse(const boost::optional<NATPortMapping>& | |
| eventLoop.stop(); | |
| } | |
| -void handleRemovePortForwardingRequestResponse(bool result) { | |
| - if (result) { | |
| +void handleRemovePortForwardingRequestResponse(const boost::optional<bool> result) { | |
| + if (result && result.get()) { | |
| std::cerr << "Result: OK" << std::endl; | |
| } | |
| else { | |
| diff --git a/Swiften/Network/BOSHConnection.cpp b/Swiften/Network/BOSHConnection.cpp | |
| index 377373d..4a9176f 100644 | |
| --- a/Swiften/Network/BOSHConnection.cpp | |
| +++ b/Swiften/Network/BOSHConnection.cpp | |
| @@ -284,7 +284,7 @@ void BOSHConnection::setSID(const std::string& sid) { | |
| void BOSHConnection::handleDisconnected(const boost::optional<Connection::Error>& error) { | |
| cancelConnector(); | |
| - onDisconnected(error); | |
| + onDisconnected(error ? true : false); | |
| sid_ = ""; | |
| connectionReady_ = false; | |
| } | |
| diff --git a/Swiften/Network/FakeConnection.cpp b/Swiften/Network/FakeConnection.cpp | |
| index be5555c..a84c92e 100644 | |
| --- a/Swiften/Network/FakeConnection.cpp | |
| +++ b/Swiften/Network/FakeConnection.cpp | |
| @@ -43,7 +43,7 @@ void FakeConnection::connect(const HostAddressPort& address) { | |
| state = DisconnectedWithError; | |
| } | |
| eventLoop->postEvent( | |
| - boost::bind(boost::ref(onConnectFinished), error), | |
| + boost::bind(boost::ref(onConnectFinished), error ? true : false), | |
| shared_from_this()); | |
| } | |
| } | |
| diff --git a/Swiften/Network/NATPMPInterface.cpp b/Swiften/Network/NATPMPInterface.cpp | |
| index 220e3e9..7d390bd 100644 | |
| --- a/Swiften/Network/NATPMPInterface.cpp | |
| +++ b/Swiften/Network/NATPMPInterface.cpp | |
| @@ -31,7 +37,7 @@ NATPMPInterface::~NATPMPInterface() { | |
| } | |
| bool NATPMPInterface::isAvailable() { | |
| - return getPublicIP(); | |
| + return getPublicIP() ? true : false; | |
| } | |
| boost::optional<HostAddress> NATPMPInterface::getPublicIP() { | |
| diff --git a/Swiften/QA/ClientTest/ClientTest.cpp b/Swiften/QA/ClientTest/ClientTest.cpp | |
| index 397921a..194c11e 100644 | |
| --- a/Swiften/QA/ClientTest/ClientTest.cpp | |
| +++ b/Swiften/QA/ClientTest/ClientTest.cpp | |
| @@ -31,7 +31,7 @@ TestStage stage; | |
| ClientOptions options; | |
| void handleDisconnected(boost::optional<ClientError> e) { | |
| - std::cout << "Disconnected: " << e << std::endl; | |
| + std::cout << "Disconnected: " << (e ? e.get().getType() : ClientError::UnknownError) << std::endl; | |
| if (stage == FirstConnect) { | |
| stage = Reconnect; | |
| client->connect(options); | |
| diff --git a/Swiften/Serializer/StreamResumeSerializer.cpp b/Swiften/Serializer/StreamResumeSerializer.cpp | |
| index e9e520d..67fd232 100644 | |
| --- a/Swiften/Serializer/StreamResumeSerializer.cpp | |
| +++ b/Swiften/Serializer/StreamResumeSerializer.cpp | |
| @@ -22,7 +22,7 @@ SafeByteArray StreamResumeSerializer::serialize(boost::shared_ptr<Element> el) c | |
| XMLElement element("resume", "urn:xmpp:sm:2"); | |
| element.setAttribute("previd", e->getResumeID()); | |
| if (e->getHandledStanzasCount()) { | |
| - element.setAttribute("h", boost::lexical_cast<std::string>(e->getHandledStanzasCount())); | |
| + element.setAttribute("h", boost::lexical_cast<std::string>(e->getHandledStanzasCount().get())); | |
| } | |
| return createSafeByteArray(element.serialize()); | |
| } | |
| diff --git a/Swiften/Serializer/StreamResumedSerializer.cpp b/Swiften/Serializer/StreamResumedSerializer.cpp | |
| index 7ae82d1..8fabc11 100644 | |
| --- a/Swiften/Serializer/StreamResumedSerializer.cpp | |
| +++ b/Swiften/Serializer/StreamResumedSerializer.cpp | |
| @@ -22,7 +22,7 @@ SafeByteArray StreamResumedSerializer::serialize(boost::shared_ptr<Element> el) | |
| XMLElement element("resumed", "urn:xmpp:sm:2"); | |
| element.setAttribute("previd", e->getResumeID()); | |
| if (e->getHandledStanzasCount()) { | |
| - element.setAttribute("h", boost::lexical_cast<std::string>(e->getHandledStanzasCount())); | |
| + element.setAttribute("h", boost::lexical_cast<std::string>(e->getHandledStanzasCount().get())); | |
| } | |
| return createSafeByteArray(element.serialize()); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment