no_double_submit_jquery.coffee

  $('#quick_entry form').live 'submit', (event) ->
    event.preventDefault()  # just moved up!
    event.stopPropagation() # just moved up!
    return false if @beenSubmitted
    @beenSubmitted = true
    clearNotice()
    $.ajax({
      type: 'POST'
      url: @action
      dataType: 'json'
      data: $(@).serialize()
      success: (response) ->
        setNotice(response.bill)
        resetAndFocusForm()
      error: (response) ->
        if response.status == 422
          setErrorFields JSON.parse(response.responseText)['error_fields']
        else
          alert("An error occurred!")
      complete: =>
        @beenSubmitted = false
    })

@sgruhier thanks, I wasn't really aware of the differences; I will use delegate. Here's an http://www.alfajango.com/blog/the-difference-between-jquerys-bind-live-and-delegate/ to illustrate the differences, in case someone else is interested.

My point on return false: http://stackoverflow.com/questions/1357118/javascript-event-preventdefault-vs-return-false/4771084#4771084

Yea I was reading through it, I think this - http://stackoverflow.com/questions/5873221/jquery-event-bubbling-and-how-click-live-click-stoppropagation-and-ret also demonstrates the same reasonably well.

@dhruvasagar thanks for the link!

Could you rewrite lines 4-7 from

if @beenSubmitted
  return false
else
  @beenSubmitted = true
... rest of the code...

to

return false if @beenSubmitted

@beenSubmitted = true
... rest of the code...

@alexrothenberg very good point, thanks

As other commenters have suggested: Just put false at the end rather than putting event.preventDefault() and event.stopPropagation() at the beginning.

You said you were concerned that if an exception is thrown, the return false won't be reached. But unless clearNotice might throw an exception, there's no chance of that; any error that occurs in $.ajax and the callbacks you give it will happen asynchronously—after the function has already returned.