Skip to content

Instantly share code, notes, and snippets.

@thelostone-mc
Last active March 31, 2018 08:37
Show Gist options
  • Save thelostone-mc/a6d1932f0920d72dec3ccd4151c891bc to your computer and use it in GitHub Desktop.
Save thelostone-mc/a6d1932f0920d72dec3ccd4151c891bc to your computer and use it in GitHub Desktop.

ES6 upgrade : Integrate babel compiler

User Story

As of this moment, the JS files are clunky and use the older syntax After discussions with folks form the community, it's been agreed upon that we'd integrate babel to enable developers use the newer syntax while ensure the compiler will take care of the backward compatibility
Possible solutions: gulp / PIPELINE / webpack

Why Is this Needed?

  • use features like let, const + arrow functions + map/reduce/filter
  • Syntax is cleaner and easier to read == better code
  • Everyone uses it
  • Ensure backward compatibility

Description

Type: Feature

Solution

Summary:

Definition of Done

Integrate babel , feed in all the files and output

Once this done, we'll open up a new PR to migrate our code to the latest ES in batches. This also gives us a chance to refactor our code ^_^


EPIC: ES6 upgrade

User Story

Post integration of ES6 compiler, we’ll be updating our pages individually. This would serve as the EPIC story which would take care of that. All the files will be listed here and each time a file gets updates (aka PR gets merged), we link the PR and updates strike out the updates file

  • bounty_details.js
  • dashboard.js [ PR: #123 ]

Description

Type: Refactor + Migration

Definition of Done

  • replace var with let, const
  • use arrow functions + map/reduce/filter
  • Bonus Points: If you can refactor the code

SCSS upgrade : Integrate SCSS compiler

User Story

Maintaining CSS files in bitcoin is clunky and we have styles getting overrides all over the place After discussions with folks form the community, it's been agreed upon that we'd SCSS compiler , transform all the .css files to .scss
Run it through the compiler and it should output css files

TODO : Define the mode of integration

Why Is this Needed?

  • use of variables to define colors and stuff
  • more maintainable css code

Description

Type: Feature

Definition of Done

Integrate SCSS , rename .css files to .scss Once this done, we'll open up a new PR to refactor our SCSS


EPIC: SCSS upgrade

User Story

Post integration of SCSS compiler, we’ll be refactoring our pages individually. This would serve as the EPIC story which would take care of that. All the files will be listed here and each time a file gets updates (aka PR gets merged), we link the PR and updates strike out the updates file

  • bounty_details.css
  • dashboard.css [ PR: #123 ]

Description

Type: Refactor + Migration

Definition of Done

  • revisit css files and remove extra classes.
  • use nested css rules + variables wherever possible
  • Bonus Points: If you can refactor the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment