Matthew therealzanfar

Python Code Review

Work in Progress

Introduction

A common request in /r/learnpython is for a review of existing code. While I have no intention of discouraging that practice, 90% of submissions include the same, basic issues. This is a list of those most common issues along with an attempt to elaborate on the issue and possible solutions.

pyenv update
pyenv versions Installed versions
pyenv install --list Availalable versions
pyenv install <versions>
pyenv global [system] <versions> Set shim priority
pyenv uninstall <versions>

This gist remains for historical reaons, however, I can no longer recommend using it.

The pracitce of using requirements.txt and simple pip dependencies is outdated and deprecated. All new projects should use a tool that supports the pyproject.toml integrated format and keeps locked versions for specified and child dependencies. My current choice is Poetry.

	"""Generic, Extensible Roshambo Game."""

	import random
	from enum import Enum
	from typing import NamedTuple


	class OptionDef(NamedTuple):
	"""Details about a throw option."""

	// ==UserScript==
	// @name Trakt History Remover
	// @namespace https://gist.github.com/therealzanfar
	// @author Matthew W.
	// @description Delete Trakt view history in bulk
	// @version 1
	// @match ://trakt.tv/users//history
	// @match ://trakt.tv/users//history/*
	// @run-at document-start
	// @grant unsafeWindow

	"logging setup": {
	"prefix": "logsetup",
	"body": [
	"import logging",
	"from rich.logging import RichHandler",
	"",
	"def setup_logging(verbosity: int = 0, force: bool = False) -> None:",
	"\t\"\"\"",
	"\tSet up a root logger with console output.",
	"",

	from collections import deque
	from typing import TypeVar, Iterable, Iterator


	T = TypeVar("T")


	def window(i: Iterable[T], size: int = 2) -> Iterator[tuple[T, ...]]:
	"""Yield a sliding window of items from an iterator."""
	i: Iterable[T] = iter(i)

	class Coord2:
	"""
	A 2-dimensional Coordinate.
	"""