Created
          July 30, 2025 18:38 
        
      - 
      
 - 
        
Save tiagovignatti/ac074506b5e6dcdfaee64db088acd2a6 to your computer and use it in GitHub Desktop.  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
  | commit 9d3d386f994562ba82a11eadf3d6fa8e25caf810 | |
| Author: Tiago Vignatti <[email protected]> | |
| Date: Wed Jul 30 11:02:45 2025 -0300 | |
| WIP | |
| --- | |
| chrome/browser/BUILD.gn | 1 - | |
| chrome/browser/ui/tabs/BUILD.gn | 5 ++++- | |
| chrome/browser/ui/views/zoom/BUILD.gn | 2 +- | |
| chrome/browser/ui/views/zoom/zoom_view_controller.cc | 3 --- | |
| 4 files changed, 5 insertions(+), 6 deletions(-) | |
| diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn | |
| index bdc9bc9f76dfe..482e0d529e9aa 100644 | |
| --- a/chrome/browser/BUILD.gn | |
| +++ b/chrome/browser/BUILD.gn | |
| @@ -4430,7 +4430,6 @@ static_library("browser") { | |
| # ... get componentized. | |
| "//chrome/browser/ui/search:impl", | |
| "//chrome/browser/ui/send_tab_to_self", | |
| - "//chrome/browser/ui/views/zoom:impl", | |
| "//chrome/browser/ui/webui/access_code_cast", | |
| "//chrome/browser/ui/webui/actor_internals", | |
| "//chrome/browser/ui/webui/app_service_internals", | |
| diff --git a/chrome/browser/ui/tabs/BUILD.gn b/chrome/browser/ui/tabs/BUILD.gn | |
| index 3e2243c925f85..7c3a7c9bf74d9 100644 | |
| --- a/chrome/browser/ui/tabs/BUILD.gn | |
| +++ b/chrome/browser/ui/tabs/BUILD.gn | |
| @@ -474,7 +474,10 @@ if (!is_android) { | |
| } | |
| if (!is_android) { | |
| - deps += [ "//chrome/browser/ui/views/zoom" ] | |
| + deps += [ | |
| + "//chrome/browser/ui/views/zoom", | |
| + "//chrome/browser/ui/views/zoom:impl" | |
| + ] | |
| } | |
| } | |
| diff --git a/chrome/browser/ui/views/zoom/BUILD.gn b/chrome/browser/ui/views/zoom/BUILD.gn | |
| index b7b4e1113cbe7..99fa62781a633 100644 | |
| --- a/chrome/browser/ui/views/zoom/BUILD.gn | |
| +++ b/chrome/browser/ui/views/zoom/BUILD.gn | |
| @@ -15,7 +15,7 @@ source_set("impl") { | |
| deps = [ | |
| ":zoom", | |
| - "//chrome/browser/ui", | |
| + "//chrome/browser:primitives", | |
| "//chrome/browser/ui:ui_features", | |
| "//chrome/browser/ui/views/page_action", | |
| "//components/zoom", | |
| diff --git a/chrome/browser/ui/views/zoom/zoom_view_controller.cc b/chrome/browser/ui/views/zoom/zoom_view_controller.cc | |
| index 556b356a16a5c..9054555be1887 100644 | |
| --- a/chrome/browser/ui/views/zoom/zoom_view_controller.cc | |
| +++ b/chrome/browser/ui/views/zoom/zoom_view_controller.cc | |
| @@ -12,9 +12,6 @@ | |
| #include "chrome/browser/ui/browser_actions.h" | |
| #include "chrome/browser/ui/tabs/public/tab_features.h" | |
| #include "chrome/browser/ui/ui_features.h" | |
| -#include "chrome/browser/ui/views/frame/browser_view.h" | |
| -#include "chrome/browser/ui/views/frame/toolbar_button_provider.h" | |
| -#include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h" | |
| #include "chrome/browser/ui/views/page_action/page_action_controller.h" | |
| #include "chrome/browser/ui/views/page_action/page_action_view.h" | |
| #include "chrome/grit/generated_resources.h" | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment