-
-
Save tilomitra/3702922 to your computer and use it in GitHub Desktop.
Comment with any issues re. the YUI Blog theme. |
- Pages are still missing.
- The category pages don't surface comments and breadcrumb is incorrect.
- By moving the author to the bottom, you'll get into a weird state when we highlight a guest author, for instance: http://yuiblogstaging.phpfogapp.com/?p=3410
Hey @jenny, could you give an example of an incorrect breadcrumb for categories? It seems to be working unless I'm missing something.
- The number of posts in each category is so light that it's practically invisible.
- In the Search results, there's a hanging | under the title, presumably left over from some navigation that doesn't get placed in there.
- 'About the author' box is weird -- the text should be all offset to the right, to appear side-by-side with the author photo.
- The breadcrumb should list the blog under "community"?
- What about the complaint that the search box is getting magically repurposed to the blog search? Maybe move the search box into its own "blog search" box on the right, and restore the top search box to be the same API/Library search box it was?
@reid I agree about the whitespace at the top (first post), but I think we should keep the whitespace between the posts, otherwise it will look like a huge run-on post.
@tilomitra I think these simply means styling the first post different (probably some <? php ?>
to add a class to the first .post
element or something…
- I actually really liked the "linen peel" headlines. :(
- The home page should have post titles be H1s, or at least share the same style (color, font-size). When you click on a headline from the home page, I feel it should look the same on the post page.
- On the home page, we don't need an H1 "blog" as well as it being in the breadcrumb (IMO).
- Breadcrumbs = Woo!
- I need a new avatar
It's looking good! I can't even tell it's a different website :)
- By-lines should use people's full names and not their username
- The search results have some margin issues
- Do we really want the FB Like and Tweet buttons on the permalink pages, them seem somewhat tacky :-/
- The comments seem indented from the left, is this on purpose?
Thanks guys, will work on these and get back to you.
@eric_f: I definitely think the tweets are valuable. Not so sure about the FB likes. I've tweeted stuff out from there before.
@ericf, @reid, @allenrabinovich, @jenny, @derek:
Thanks for your input guys. I've made the following fixes:
- Fixed margin issues on search page
- Fixed incorrect categories in breadcrumbs
- Meta uses author's full name.
- Fixed styling of guest authors (this is something we should change going forward, because guest author meta information is inside the post right now.)
- Fixed the padding/margins on the first post
- The posts on the blog roll now look more like
<h1>
instead of the orange<h2>
to maintain consistency. - Added pages to the sidebar
- Fixed comment styling for threaded comments
- Moved the bottom navigation further away from the post.
- Got rid of the trailing
|
after "Older Posts"
Some of the things I did not fix:
- @Allenr: We decided on keeping the search bar there. It says "Search the blog" so I don't think it's confusing. I don't think people will do an API Search from the blog, in any case.
- @ericf: I tried the comments without indentation but it didn't feel right. Try it out in the console. I felt like there was too much whitespace on the right. Plus, once people reply to other comments, the indentation starts to make sense.
- @derek: I didn't change the headings on the blog roll to be the same size as the
<h1>
on the single-post page. That size was just too big for a dozen odd headers.
Let me know what you guys think about these.
Can you reinstate the "recent posts" sidebar?
This looks great. I just notice weird whitespace between posts on the index and category pages:
Also, the "Older Entries" links on the header (category pages only) and footer have a "|" next to them, plus they are too close to the posts (footer only) and could use come padding.
Single post, comments, comment form all look great.