Skip to content

Instantly share code, notes, and snippets.

@tmehta2442
Created October 28, 2013 20:17
Show Gist options
  • Select an option

  • Save tmehta2442/7203815 to your computer and use it in GitHub Desktop.

Select an option

Save tmehta2442/7203815 to your computer and use it in GitHub Desktop.
Refactoring ideas for codemapsalpha
- Views, Offline_schools: index.html.erb
maybe move the js files into assets->javascripts
- Views, offline_schools: new.html.erb
maybe move the js files into assets->javascripts
- Views, offline_schools: show.html.erb
maybe move the js files into assets->javascripts
Ordinarily, JS functions should be placed in the assets-> javascripts folder. From my experience, moving the JS into the appropriate assets folder is relatively easy (even if it includes AJAX). Note that the <script> & </script> tags are not needed. A great helper:
http://stackoverflow.com/questions/3437585/best-way-to-add-page-specific-javascript-in-a-rails-3-app
- Views, Offline_schools: index.html.erb
JS & AJAX the same
- Views, offline_schools: new.html.erb
JS & AJAX the same
Instead of making two Javascript asset files, you can make just one and call on it when needed. Also, you may be able to take out the similiar AJAX portion, have it in a separate file, and call on it when needed.
- Views, online_schools: index.html.erb
instead of breaks try to use a table
- Views, quotes: index.html.erb
instead of breaks try to use a table
There may be more examples of using <br> to apply style changes, but we want to try to use CSS as much as possible for styling rather than html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment