Skip to content

Instantly share code, notes, and snippets.

@tmikeschu
Last active November 10, 2016 20:28
Show Gist options
  • Save tmikeschu/ddcc510410f861da7b21126e90d97d7a to your computer and use it in GitHub Desktop.
Save tmikeschu/ddcc510410f861da7b21126e90d97d7a to your computer and use it in GitHub Desktop.

A: Opportunity for improvement

  • Jason and I could have split out our analyst class more with def_delegators. We still had a couple hefty classes with gray area in terms of responsibility scope.

    I also think we could have done a better job implementing mock tests somehow. It seems like a lot of the integration tests would be ideal for this, but implementing the mock was much harder than expected (e.g., method calls multiple mocks that lead to other methods).

B: My role

  • From my perspective, my role was to continunously come back to the macro/conceptual view of the project in a way that would define our next steps more meaningfully. I played more of a lead role in refactoring, breaking out logic, TDD, but once I set a basic model, Jason was great at future iterations of similar concepts.

C: Jason's role

  • Jason did an awesome job getting things running once we built the base repositories together. He's a primary reason we made huge strides in the middle part of the project. He also spearheaded the Google Charts extension, which allowed me to research more refactoring options (e.g., def_delegators).

D: Dynamic improvements

  • Overall, I feel good about the pair dynamic we had. We did have a couple Git merge conflicts in the beginning, which was frustrating. We could have improved this by explicitly stating our git protocol in the DTR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment