Last active
April 17, 2019 06:47
-
-
Save tobiasschuerg/5dd116e1e0bb874038d84fd98cc333c3 to your computer and use it in GitHub Desktop.
SupportDatePickerDialog for working around IllegalFormatConversionException on Samsung 5.0 and Samsung 5.1. Inspired by http://stackoverflow.com/a/31855744/570168
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import android.app.DatePickerDialog; | |
import android.content.Context; | |
import android.os.Build; | |
import android.support.annotation.NonNull; | |
import android.support.annotation.Nullable; | |
import android.support.annotation.RequiresApi; | |
import android.support.annotation.StyleRes; | |
import android.support.v7.view.ContextThemeWrapper; | |
/** | |
* Support {@link DatePickerDialog} for working around Samsung 5 {@link java.util.IllegalFormatConversionException} bug. | |
* <p> | |
* > Fatal Exception: java.util.IllegalFormatConversionException: %d can't format java.lang.String arguments | |
* <p> | |
* Created by Tobias Schürg | |
* Based on http://stackoverflow.com/a/31855744/570168 | |
*/ | |
public class SupportDatePickerDialog extends DatePickerDialog { | |
@RequiresApi(api = Build.VERSION_CODES.N) | |
public SupportDatePickerDialog(@NonNull Context context) { | |
super(fixContext(context)); | |
} | |
@RequiresApi(api = Build.VERSION_CODES.N) | |
public SupportDatePickerDialog(@NonNull Context context, @StyleRes int themeResId) { | |
super(fixContext(context), themeResId); | |
} | |
public SupportDatePickerDialog(@NonNull Context context, @Nullable OnDateSetListener listener, int year, int month, int dayOfMonth) { | |
super(fixContext(context), listener, year, month, dayOfMonth); | |
} | |
public SupportDatePickerDialog(@NonNull Context context, @StyleRes int themeResId, @Nullable OnDateSetListener listener, int year, int monthOfYear, int dayOfMonth) { | |
super(fixContext(context), themeResId, listener, year, monthOfYear, dayOfMonth); | |
} | |
/** | |
* Wraps the {@link Context} to use the holo theme to avoid stupid bug on Samsung devices. | |
*/ | |
private static Context fixContext(Context context) { | |
if (isBrokenSamsungDevice()) { | |
return new ContextThemeWrapper(context, android.R.style.Theme_Holo_Light_Dialog); | |
} else { | |
return context; | |
} | |
} | |
/** | |
* Affected devices: | |
* - Samsung 5.0 | |
* - Samsung 5.1 | |
* | |
* @return true if device is affected by this bug. | |
*/ | |
private static boolean isBrokenSamsungDevice() { | |
return (Build.MANUFACTURER.equalsIgnoreCase("samsung") | |
&& Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP | |
&& Build.VERSION.SDK_INT <= Build.VERSION_CODES.LOLLIPOP_MR1); | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See my answer here: http://stackoverflow.com/questions/28618405/datepicker-crashes-on-my-device-when-clicked-with-personal-app/34853067#34853067