Created
November 4, 2023 13:15
-
-
Save torarnv/1654a4965e89b9108c9fe9ef51e3f36a to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 7f7e13844221b850780086cf916796123d8f196e | |
Author: Tor Arne Vestbø <[email protected]> | |
Date: Sat Nov 4 14:11:12 2023 +0100 | |
gpush: Don't use exsha1 as a SCALAR ref when checking duplicate change IDs | |
Change-Id: I3f7b2964316393b70a70e5b2dfe4b0f2261ec012 | |
diff --git a/bin/git_gpush.pm b/bin/git_gpush.pm | |
index 36e9891..684e7c2 100644 | |
--- a/bin/git_gpush.pm | |
+++ b/bin/git_gpush.pm | |
@@ -1447,7 +1447,7 @@ sub analyze_local_branch($) | |
my $exsha1 = $changeid2local{$changeid}; | |
fail("Duplicate Change-Id $changeid on " | |
.($local_branch // "<detached HEAD>").":\n " | |
- .format_subject($$exsha1, $commit_by_id{$exsha1}{subject}, -2) | |
+ .format_subject($exsha1, $commit_by_id{$exsha1}{subject}, -2) | |
."\n ".format_subject($sha1, $subject, -2)."\n") | |
if (defined($exsha1)); | |
# This both serves as a seen check, and feeds parse_local_rev(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment