udacityandroid/onCreate method in MainActivity.java

yuri117 · 2018-12-22T21:27:12Z

Note: If you don't want to create a Intent class, you can simply call the Intent constructor INSIDE the startActivity() method, like this:

TextView numbers = findViewById(R.id.numbers);

    numbers.setOnClickListener(new View.OnClickListener(){
        @Override
        public void onClick(View v){
            startActivity(new Intent(MainActivity.this, NumbersActivity.class));
        }
    });
}

yuri117 · 2018-12-22T21:31:41Z

Very smart solution, @ZetFury. Congrats!

a7bekjnoon · 2019-04-17T16:09:09Z

/*

Copyright (C) 2016 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

 http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package com.example.android.miwok;

import android.content.Intent;
import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.TextView;

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    // Set the content of the activity to use the activity_main.xml layout file
    setContentView(R.layout.activity_main);

    //Find the view which shows the numbers category
    TextView numbers = (TextView) findViewById(R.id.numbers);

//Set a click listener on that view
numbers.setOnClickListener(new View.OnClickListener() {
// The code in this method will be called when the numbers view is clicked on.
@OverRide
public void onClick(View view) {
Intent numbersIntent = new Intent(MainActivity.this, NumbersActivity.class);
startActivity(numbersIntent);
}

    });

    //Find the view which shows the family category.
    TextView family = (TextView) findViewById(R.id.family);

//Set a click listener on that view.
family.setOnClickListener(new View.OnClickListener() {
//The code in this method will be called when the family view is clicked on.
@OverRide
public void onClick(View view) {
Intent familyIntent = new Intent(MainActivity.this, FamilyActivity.class);
startActivity(familyIntent);
}
});

    //Find the view which shows the colors category.
    TextView colors = (TextView) findViewById(R.id.colors);

//Set a click listener on that view.
colors.setOnClickListener(new View.OnClickListener() {
//The code in this method will be called when the colors view is clicked on.
@OverRide
public void onClick(View view) {
Intent colorsIntent = new Intent(MainActivity.this, ColorsActivity.class);
startActivity(colorsIntent);
}
});

    //Find the view which shows the colors category.
    TextView phrases = (TextView) findViewById(R.id.phrases);

//Set a click listener on that view.
phrases.setOnClickListener(new View.OnClickListener() {
//The code in this method will be called when the colors view is clicked on.
@OverRide
public void onClick(View view) {
Intent phrasesIntent = new Intent(MainActivity.this, PhrasesActivity.class);
startActivity(phrasesIntent);
}

    });
}

}

MikeySmash · 2019-05-11T08:10:50Z

I love this onClickListener solution by @rzettervall : https://gist.github.com/udacityandroid/d5826cdde2e0591c0162452f48f6be2d#gistcomment-2755339

menuClick(findViewById(R.id.numbers),this,NumbersActivity.class);
menuClick(findViewById(R.id.phrases),this,PhrasesActivity.class);
menuClick(findViewById(R.id.colors),this,ColorsActivity.class);
menuClick(findViewById(R.id.family),this,FamilyActivity.class);
}

private void menuClick(View v, final Context context, final Class target) {
v.setOnClickListener(new View.OnClickListener() {
@OverRide
public void onClick(View view) {
Intent i = new Intent(context,target);
startActivity(i);
}
});

I've adapted it using @felipisan shortened version to get this:

    // Finds correct view and sets the target for menuClick
    menuClick(findViewById(R.id.imageNumbers),this,numbers.class);
    menuClick(findViewById(R.id.imagePhrases),this,phrases.class);
    menuClick(findViewById(R.id.imageColour),this,colours.class);
    menuClick(findViewById(R.id.imageFamily),this,family.class);
}
// Sets the on click listener using appropriate target then opens this activity
private void menuClick(View v, final Context context, final Class target) {
    v.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            startActivity(new Intent(context,target));
        }
    });

sheikhrasik · 2019-07-31T10:01:57Z

I created the intents as directed in the video in the onClick() method. The app runs just fine but once i click the textViews on my device it doesn't move to the particular activity.For example if i click the numbers text view it should shift to the numbers activity but it does nothing at all. Please help

public void opensNumbersList(View v) {
// Find the View that shows the numbers category
TextView numbers = (TextView) findViewById(R.id.numbers);

    // Set a click listener on that View
    numbers.setOnClickListener(new View.OnClickListener() {
        // The code in this method will be executed when this view is clicked on.
        @Override
        public void onClick(View v) {
           Intent numbersIntent = new Intent(MainActivity.this , NumbersActivity.class);
            startActivity(numbersIntent);
        }
    });
}

xMagicXs · 2019-09-09T16:23:37Z

this worked for me

// Find the View that shows the numbers category
TextView numbers = (TextView) findViewById ( R.id.numbers );

// Set a click listener on that View
if ( numbers !=null){
//Set a click listener on that View
numbers.setOnClickListener ( new View.OnClickListener () {
//The code in this method will be executed when the family View is clicked on.
@OverRide
public void onClick(View v) {
Intent numbersIntent = new Intent ( MainActivity.this, NumbersActivity.class );
startActivity ( numbersIntent );
}
} );
}
//Find the view that shows family cathegory
TextView family = (TextView)findViewById ( R.id.family );

    //Set a click listener on that View
    if ( family != null){
        family.setOnClickListener ( new View.OnClickListener () {
            //The code in this method will be executed when the family View is clicked on.
            @Override
            public void onClick(View v) {
                Intent familyIntent = new Intent ( MainActivity.this, FamilyActivity.class );
                startActivity ( familyIntent );
            }
        } );
    }
    //Find the view that shows colors cathegory
    TextView colors = (TextView) findViewById ( R.id.colors );

    //Set a click listener on that View
    if (colors != null){
        colors.setOnClickListener ( new View.OnClickListener () {
            //The code in this method will be executed when the colors View is clicked on.
            @Override
            public void onClick(View v) {
                Intent colorsIntent = new Intent ( MainActivity.this, ColorsActivity.class );
                startActivity ( colorsIntent );
            }
        } );
    }
    //Find the view that shows phrases cathegory
    TextView phrases = (TextView) findViewById ( R.id.phrases );

    //Set a click listener on that View
    if ( phrases != null){
        phrases.setOnClickListener ( new View.OnClickListener () {
            //The code in this method will be executed when the phrases View is clicked on.
            @Override
            public void onClick(View v) {
                Intent phrasesIntent = new Intent ( MainActivity.this, PhrasesActivity.class );
                startActivity ( phrasesIntent );
            }
        } );
    }
}

lak4ever · 2019-10-27T14:02:22Z

I created the intents as directed in the video in the onClick() method. The app runs just fine but once i click the textViews on my device it doesn't move to the particular activity.For example if i click the numbers text view it should shift to the numbers activity but it does nothing at all. Please help

public void opensNumbersList(View v) {
// Find the View that shows the numbers category
TextView numbers = (TextView) findViewById(R.id.numbers);
    // Set a click listener on that View
    numbers.setOnClickListener(new View.OnClickListener() {
        // The code in this method will be executed when this view is clicked on.
        @Override
        public void onClick(View v) {
           Intent numbersIntent = new Intent(MainActivity.this , NumbersActivity.class);
            startActivity(numbersIntent);
        }
    });
}

(new View.OnClickListener() please look carefully with this part is it new view or something else?

mudasiri · 2019-11-17T11:13:17Z

Why do we pass (MainActviity,this, NumbersActivity,class) instead of (this, NumbersActivity.class)

That's because MainActivity.this - is specifying the context clearly. When you are in an inner function it's best to state the context class fully rather than just using the 'this'. thus to help solve any issues that hans to do with scope resolutions.

seghier · 2019-11-20T12:41:19Z

This work fine

package com.example.android.miwok;

import android.content.Intent;
import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.TextView;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        // Set the content of the activity to use the activity_main.xml layout file
        setContentView(R.layout.activity_main);

        //attach the listener to the view
        TextView numbers = (TextView)findViewById(R.id.numbers);
        numbers.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Intent numbersIntent = new Intent(MainActivity.this,NumbersActivity.class);
                startActivity(numbersIntent);
            }
        });
        TextView colors = (TextView)findViewById(R.id.colors);
        colors.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Intent colorsIntent = new Intent(MainActivity.this,ColorsActivity.class);
                startActivity(colorsIntent);
            }
        });
        TextView family = (TextView)findViewById(R.id.family);
        family.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Intent familyIntent = new Intent(MainActivity.this,FamilyActivity.class);
                startActivity(familyIntent);
            }
        });
        TextView phrases = (TextView)findViewById(R.id.phrases);
        phrases.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                Intent phrasesIntent = new Intent(MainActivity.this,PhrasesActivity.class);
                startActivity(phrasesIntent);
            }
        });

    }

}

HMVinueza · 2019-12-12T03:25:26Z

I want to share my version of the code:

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    // Set the content of the activity to use the activity_main.xml layout file
    setContentView(R.layout.activity_main);

    //Number Listener
    setListenerOpenActivity(findViewById(R.id.numbers),NumbersActivity.class);
    setListenerOpenActivity(findViewById(R.id.colors),ColorsActivity.class);
    setListenerOpenActivity(findViewById(R.id.phrases),PhrasesActivity.class);
    setListenerOpenActivity(findViewById(R.id.family),FamilyActivity.class);

}

public void setListenerOpenActivity (View view, final Class cActivity){
    view.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            startActivity(new Intent(MainActivity.this,cActivity));
        }
    });
}

}

adda1 · 2019-12-26T20:58:30Z

When i write this code, the word setOnClickListener becimes red and says cannot resolve symbol. Why is this happening?

write the code inside of onCreate method.

Ahmed-Salim-93 · 2020-05-27T15:13:24Z

Hi, my code is working just fine without problems.
The only issue is that in the video there is a back button in the title bar, but, is my program there isn't.
Does anyone know why is that happening and how to solve this problem?

IQ-Hammurabi · 2020-06-03T21:10:26Z

for any one faces problems :

please make sure to paste the code inside onCreate method , otherwise the setOnClickListener will be RED, as below :

super.onCreate(savedInstanceState);

    // Set the content of the activity to use the activity_main.xml layout file
    setContentView(R.layout.activity_main);
    TextView numbers = (TextView) findViewById(R.id.numbers);
    numbers.setOnClickListener(new View.OnClickListener() {
        // The code in this method will be executed when the numbers View is clicked on.
        @Override
        public void onClick(View view) {
            Intent numbersIntent = new Intent(MainActivity.this, NumbersActivity.class);
            startActivity(numbersIntent);
        }
    });

2)please make sure that all these imports are in your MainActivity.java

import android.content.Intent;
import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.TextView;

noob-droid · 2020-06-17T19:37:07Z

Please check if you've pasted this code within the onCreate method.

thank you for the solution. i am sort of curious though, why shall it be within the onCreate method?

harshavardhan3199 · 2020-06-26T17:50:35Z

I think I'm the only one who things Katherine teaching is way better than the current one.

Elghandour2020 · 2020-06-29T07:46:04Z

harshavardhan3199
Me too bro

SultonN · 2020-08-21T04:22:16Z

I want to share my version of the code:

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    // Set the content of the activity to use the activity_main.xml layout file
    setContentView(R.layout.activity_main);

    //Number Listener
    setListenerOpenActivity(findViewById(R.id.numbers),NumbersActivity.class);
    setListenerOpenActivity(findViewById(R.id.colors),ColorsActivity.class);
    setListenerOpenActivity(findViewById(R.id.phrases),PhrasesActivity.class);
    setListenerOpenActivity(findViewById(R.id.family),FamilyActivity.class);

}

public void setListenerOpenActivity (View view, final Class cActivity){
    view.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            startActivity(new Intent(MainActivity.this,cActivity));
        }
    });
}

}

@Goood

vaibhavbhardwaj201 · 2020-09-19T00:35:45Z

Why do we pass (MainActviity,this, NumbersActivity,class) instead of (this, NumbersActivity.class)

Because we are in the Anonymous inner class. Class inside other class.

Abhilashtyagi007 · 2020-09-24T08:25:07Z

put this code into the onCreate method

yaz71 · 2020-09-28T15:58:36Z

Question : do we have to copy past the code for all 4 categories ? or is it possible to just build one onclicklistener class and then use it on the 4 different textView objects ?

yaz71 · 2020-09-28T16:08:49Z

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    // Set the content of the activity to use the activity_main.xml layout file
    setContentView(R.layout.activity_main);
    TextView numbers= (TextView)findViewById(R.id.numbers);
    TextView phrases = (TextView)findViewById(R.id.phrases);
    TextView family = (TextView)findViewById(R.id.family);
    TextView colors = (TextView)findViewById(R.id.colors);

    numbers.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            Intent Numb = new Intent(MainActivity.this, numbersActivity.class);
            startActivity(Numb);
        }
    });

    phrases.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            Intent phrase = new Intent(MainActivity.this, phrasesActivity.class);
            startActivity(phrase);
        }
    });

    family.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            Intent fam = new Intent(MainActivity.this, familyMembersActivity.class);
            startActivity(fam);
        }
    });

    colors.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            Intent col = new Intent(MainActivity.this, colorsActivity.class);
            startActivity(col);
        }
    });
}

}

Here's my code, but I don't like the too much repetition :/ is there like an IF statement or a switch to use to implement this in less lines?

ghost · 2020-10-01T19:27:22Z

setOnClickListener

same with me

Ahmostafaa · 2020-12-01T20:50:42Z

Can anyone tell me what's wrong ?

noxicus · 2021-01-21T09:29:39Z

Can anyone tell me what's wrong ?

Check your brackets and semicolons

nitish778191 · 2021-01-31T18:05:45Z

Can anyone explain this line of code please!

bmramyabm · 2021-03-05T03:52:13Z

Please check if you've pasted this code within the onCreate method.

Thanks

Rishabh5752 · 2021-05-20T16:38:25Z

is anyone lost like me? :(

yes, i don't understand a single word of the video

n0obs73r · 2021-05-28T11:06:50Z

Can anyone explain this line of code please!

The first Parameter you are passing is the context of current activity because in case you want to press back after going to the next activity it'll act as a link and the next one is pretty self explanatory (it is passing the class you want to go to after clicking on the view).

wdoodoo · 2021-07-20T02:00:21Z

Hello, fellow coders.

I am sharing code based on my development environment as below.
I am using Android Studio 4.2.2, Build #AI-202.7660.26.42.7486908, built on June 24, 2021, Runtime version: 11.0.8+10-b944.6842174 amd64, VM: OpenJDK 64-Bit Server VM by N/A
openjdk version "11.0.10" 2021-01-19
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.10+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.10+9, mixed mode)

The MainActivity.java code is look like this and it works for me.
Hope this is helpful for someone out there. Happy coding!

``
package com.tutorial.android.miwok;

import androidx.appcompat.app.AppCompatActivity;

import android.content.Intent;
import android.os.Bundle;
import android.widget.TextView;

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

     TextView numbers = findViewById(R.id.numbers);
     numbers.setOnClickListener(view -> {

        Intent numbersIntent = new Intent(this, NumbersActivity.class);
        startActivity(numbersIntent);
    });

    TextView family = findViewById(R.id.family);

    family.setOnClickListener(view -> {
        Intent familyIntent = new Intent(this, FamilyActivity.class);
        startActivity(familyIntent);
    });

    TextView colors = findViewById(R.id.colors);

    colors.setOnClickListener(view -> {

        Intent colorsIntent = new Intent(this, ColorsActivity.class);
        startActivity(colorsIntent);
    });

    TextView phrases = findViewById(R.id.phrases);

    phrases.setOnClickListener(view -> {

        Intent phrasesIntent = new Intent(this, PhrasesActivity.class);
        startActivity(phrasesIntent);
    });
}

}

Harriskobia · 2022-05-24T05:03:26Z

Note: If you don't want to create a Intent class, you can simply call the Intent constructor INSIDE the startActivity() method, like this:

TextView numbers = findViewById(R.id.numbers);
    numbers.setOnClickListener(new View.OnClickListener(){
        @Override
        public void onClick(View v){
            startActivity(new Intent(MainActivity.this, NumbersActivity.class));
        }
    });
}

This is actually nice

udacityandroid/onCreate method in MainActivity.java

yuri117 commented Dec 22, 2018 •

edited

Loading

yuri117 commented Dec 22, 2018

a7bekjnoon commented Apr 17, 2019

MikeySmash commented May 11, 2019

sheikhrasik commented Jul 31, 2019

xMagicXs commented Sep 9, 2019 •

edited

Loading

lak4ever commented Oct 27, 2019

mudasiri commented Nov 17, 2019

seghier commented Nov 20, 2019 •

edited

Loading

HMVinueza commented Dec 12, 2019

adda1 commented Dec 26, 2019

Ahmed-Salim-93 commented May 27, 2020

IQ-Hammurabi commented Jun 3, 2020

noob-droid commented Jun 17, 2020

harshavardhan3199 commented Jun 26, 2020

Elghandour2020 commented Jun 29, 2020

SultonN commented Aug 21, 2020

vaibhavbhardwaj201 commented Sep 19, 2020

Abhilashtyagi007 commented Sep 24, 2020

yaz71 commented Sep 28, 2020

yaz71 commented Sep 28, 2020

ghost commented Oct 1, 2020

Ahmostafaa commented Dec 1, 2020

noxicus commented Jan 21, 2021

nitish778191 commented Jan 31, 2021

bmramyabm commented Mar 5, 2021

Rishabh5752 commented May 20, 2021

n0obs73r commented May 28, 2021

wdoodoo commented Jul 20, 2021

Harriskobia commented May 24, 2022

	// Find the View that shows the numbers category
	TextView numbers = (TextView) findViewById(R.id.numbers);

	// Set a click listener on that View
	numbers.setOnClickListener(new View.OnClickListener() {
	// The code in this method will be executed when the numbers View is clicked on.
	@Override
	public void onClick(View view) {
	Intent numbersIntent = new Intent(MainActivity.this, NumbersActivity.class);
	startActivity(numbersIntent);
	}
	});

udacityandroid/onCreate method in MainActivity.java

yuri117 commented Dec 22, 2018 • edited Loading

yuri117 commented Dec 22, 2018

a7bekjnoon commented Apr 17, 2019

MikeySmash commented May 11, 2019

sheikhrasik commented Jul 31, 2019

xMagicXs commented Sep 9, 2019 • edited Loading

lak4ever commented Oct 27, 2019

mudasiri commented Nov 17, 2019

seghier commented Nov 20, 2019 • edited Loading

HMVinueza commented Dec 12, 2019

adda1 commented Dec 26, 2019

Ahmed-Salim-93 commented May 27, 2020

IQ-Hammurabi commented Jun 3, 2020

noob-droid commented Jun 17, 2020

harshavardhan3199 commented Jun 26, 2020

Elghandour2020 commented Jun 29, 2020

SultonN commented Aug 21, 2020

vaibhavbhardwaj201 commented Sep 19, 2020

Abhilashtyagi007 commented Sep 24, 2020

yaz71 commented Sep 28, 2020

yaz71 commented Sep 28, 2020

ghost commented Oct 1, 2020

Ahmostafaa commented Dec 1, 2020

noxicus commented Jan 21, 2021

nitish778191 commented Jan 31, 2021

bmramyabm commented Mar 5, 2021

Rishabh5752 commented May 20, 2021

n0obs73r commented May 28, 2021

wdoodoo commented Jul 20, 2021

Harriskobia commented May 24, 2022

yuri117 commented Dec 22, 2018 •

edited

Loading

xMagicXs commented Sep 9, 2019 •

edited

Loading

seghier commented Nov 20, 2019 •

edited

Loading