-
-
Save ufuk/0ccb87185c22475c64d46801fa160777 to your computer and use it in GitHub Desktop.
import lombok.AllArgsConstructor; | |
import lombok.Data; | |
@Data | |
@AllArgsConstructor | |
public class LazyDeveloper { | |
private String firstName; | |
private String lastName; | |
} |
import org.junit.Test; | |
import static org.hamcrest.Matchers.equalTo; | |
import static org.junit.Assert.assertThat; | |
public class LazyDeveloperTest { | |
@Test | |
public void testAllArgsConstructor() { | |
LazyDeveloper lazyDeveloper = new LazyDeveloper("John", "Doe"); | |
assertThat(lazyDeveloper.getFirstName(), equalTo("John")); | |
assertThat(lazyDeveloper.getLastName(), equalTo("Doe")); | |
} | |
} |
If you change the order of fields, for example:
...
@AllArgsConstructor
public class LazyDeveloper {
private String lastName;
private String firstName;
}
Code will be compiled but test will fail, so your expectation will not be satisfied. Because first param of the newly auto-gerenated constructor will be "lastName".
I think that is a great risk when you use Lombok but don't write unit tests.
sorry for the grave-digging, but I just wanted to clarify for anyone that stumbles upon this.
Your "problem" could be easily replicated with plain java:
public LazyDeveloper(String lastName, String firstName){}
public LazyDeveloper(String firstName, String lastName){}
There's no signature change; code will still compile fine; you still need unit tests.
I understand that it's simpler to do such mistakes with Lombok, but,
such constructors are dangerous anyway in large projects, they should be avoided regardless of using Lombok or not.
It also goes without saying that you need junit tests regardless of using Lombok or not :)
@Kidlike great addition, thank you. I encountered such a situation when using Lombok and just noted it.
Hi Ufuk, what is the problem here?