refactored_v1.java

public class OnlineStatus {
    private int recentOnlineThresholdDays;
    private int onlineThresholdHrs;

    public enum States {Unknown, Online, Recent}

    public void setOnlineThresholdHrs(int hours) {
        this.onlineThresholdHrs = hours;
    }

    public void setRecentOnlineThresholdDays(int days) {
        this.recentOnlineThresholdDays = days;
    }

    public States getStatus(Date lastOnline, Calendar calendar) {
        if (onlineThresholdHrs <= 0) {
            throw new IllegalArgumentException("Requires online threshold in hours");
        }

        int currentHour = calendar.get(Calendar.HOUR_OF_DAY);
        int currentDay = calendar.get(Calendar.DAY_OF_YEAR);

        States state = States.Unknown;

        if (hitsThreshold(
                Calendar.DAY_OF_YEAR,
                currentDay - recentOnlineThresholdDays,
                lastOnline)) {
            state = States.Recent;
        }
        
        if (hitsThreshold(
                Calendar.HOUR_OF_DAY,
                currentHour - onlineThresholdHrs,
                lastOnline)) {
            state = States.Online;
        }

        return state;
    }

    private boolean hitsThreshold(int calenderField, int value, Date time) {
        Calendar calendar = Calendar.getInstance();
        calendar.set(
                calenderField,
                value
        );
        Date threshold = calendar.getTime();
        return time.after(threshold);
    }
}