viniciusjssouza

Hiero Consensus Node -- Code Review Guidelines

---

1. Determinism

Determinism is the single most critical property of this codebase. Every consensus node must process every transaction identically. A violation causes an ISS (Invalid State Signature), which takes nodes offline.

Use Ordered, Deterministic Collections

viniciusjssouza

Here are the wiring diagrams split by stage. Boxes are repeated where a module participates in multiple stages.

---

Stage 1 — gRPC Request Processing (Client → Transaction Pool)

flowchart TD
    CLIENT["🌐 External Client\n(gRPC call)"]

viniciusjssouza

# Use ${idea.home.path} macro to specify location relative to IDE installation home.
# Use ${xxx} where xxx is any Java property (including defined in previous lines of this file) to refer to its value.
# Note for Windows users: please make sure you're using forward slashes: C:/dir1/dir2.

#---------------------------------------------------------------------
# Uncomment this option if you want to customize a path to the settings directory.
#---------------------------------------------------------------------
# idea.config.path=${user.home}/.GoLand/config

#---------------------------------------------------------------------

viniciusjssouza

######## BEGIN IDE OPTIONS ########
# Add additional options outside this section as they will be overwritten on every IDE startup #

# Select the Java Server VM.
-server

# Set default just-in-time compiled code cache size.
-XX:ReservedCodeCacheSize=768m

# Mark softly-reachable objects' lifespan per megabyte of maximum memory heap size.

viniciusjssouza

# replace "REPLACE_ME_IAM_KEY_PATTERN" with your key pattern that you want to delete local
# to paste this in a redis-cli session, remove the new lines and put everything in an `EVAL "everythin here" 0` command
local cursor='0';
local count = 0;
repeat
    local scanResult = redis.call('SCAN', cursor, 'MATCH', 'somekey.*', 'COUNT', 100);
    local keys = scanResult[2];
    for i = 1, #keys
    do
        local key = keys[i];

viniciusjssouza

docker exec -it <container id> sh -c "ls -alh  > /proc/1/fd/1"

viniciusjssouza

curl -u $USERNAME:$PASSWORD -s https://api.github.com/orgs/$ORG/repos?per_page=200 | jq -rc '.[] | {ssh_url} | .ssh_url' | parallel -n 1 git clone {}

viniciusjssouza

mysqldump db --skip-disable-keys --skip-add-locks --skip-add-drop-table --skip-lock-tables --result-file="output.sql" --skip-extended-insert --no-data --skip-create-options --column-statistics=0

viniciusjssouza

Code Reviews

Functionality (high)

• Do the code provide the desired functionality correctly? Are there any possible bugs?

Tests (high)

• Does the code have tests for all the "complex" logics in it?
• Are the tests maintainable and well designed?
• Do they respect the test pyramid to avoid taking so much time to run?

viniciusjssouza

RabbitMQ (AMQP) model

AMQP

Protocolo aberto da camada de aplicação para comunicação entre clientes e brokers de mensagens. Executa sobre o TCP, com payloads binários.

Entidades envolvidas

• publisher: processo que publica mensagens;
• exchange: "mailboxes" onde as mensagens são publicadas;
• queue: fila de destino das mensagens;