and-all-conditions.c

static OSStatus SSLVerifySignedServerKeyExchange() {
  err = (ReadyHash(&SSLHashSHA1, &hashCtx) != 0) &&
        (SSLHashSHA1.Update(&hashCtx, &clientRandom) != 0) &&
        (SSLHashSHA1.Update(&hashCtx, &serverRandom) != 0) &&
        (SSLHashSHA1.Update(&hashCtx, &signedParams) != 0) &&
        (SSLHashSHA1.final(&hashCtx, &hashOut) != 0);

  freeBuffer(&hashCtx);
  return err;
}

complex-example.c

bool_t someFunction() {
  char *c = NULL;
  int  *i = NULL;
  int  *j = NULL;
  
  c = malloc(10);
  if (NULL == c) {
    /* Handle failure and exit */
  }
  
  i = malloc(10 * sizeof(*i));
  if (NULL == i) {
    /* Free c, handle failure and exit */
  }
  
  j = malloc(10 * sizeof(*j));
  if (NULL == j) {
    /* Free c, free i, handle failure and exit */
  }
  
  return true
}

example.c

static OSStatus SSLVerifySignedServerKeyExchange() {
  if ((err = ReadyHash(&SSLHashSHA1, &hashCtx)) != 0) {
    return err;
  }
  
  if ((err = SSLHashSHA1.Update(&hashCtx, &clientRandom)) != 0) {
    freeBuffer(&hashCtx);
    return err;
  }
  
  if ((err = SSLHashSHA1.Update(&hashCtx, &serverRandom)) != 0) {
    freeBuffer(&hashCtx);
    return err;
  }
  
  if ((err = SSLHashSHA1.Update(&hashCtx, &signedParams)) != 0) {
    freeBuffer(&hashCtx);
    return err;
  }
  
  if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0) {
    freeBuffer(&hashCtx);
    return err;
  }
  
  freeBuffer(&hashCtx);
  return err;
}

Goto hell.md

Code snippets for "goto hell" blog post at http://www.apokrupto.com/blog-1/2016/3/17/9y5wmrds7ar9mw8o7q6pyx5c4yi743

goto.c

#define FAIL() do { ret = false; goto cleanup; } while(0)

bool_t someFunction() {
  bool_t ret = true;
  char  *c = NULL;
  int   *i = NULL;
  int   *j = NULL;
  
  c = malloc(10);
  if (NULL == c) {
    FAIL();
  }
  
  i = malloc(10 * sizeof(*i));
  if (NULL == i) {
    FAIL();
  }
  
  j = malloc(10 * sizeof(*j));
  if (NULL == j) {
    FAIL();
  }
  
cleanup:
  free(c);
  free(i);
  free(j);
  
  return ret;
}

important-check-with-braces.c

bool_t checkForSomethingReallyImportant(void) {
  if (isThatImportantThingOk()) {
    return true;
  }
    return true;
    
  return false;
}

important-check.c

bool_t checkForSomethingReallyImportant(void) {
  if (isThatImportantThingOk())
    return true;
    return true;
    
  return false;
}

rewrite-example.c

static OSStatus SSLVerifySignedServerKeyExchange() {
  if ((err = ReadyHash(&SSLHashSHA1, &hashCtx)) != 0) {
    if ((err = SSLHashSHA1.Update(&hashCtx, &clientRandom)) != 0) {
      if ((err = SSLHashSHA1.Update(&hashCtx, &serverRandom)) != 0) {
        // ...
      }
    }
  }
 
  freeBuffer(&hashCtx);
  return err;
}