Early Return Developer vs. OpenAI ChatGTP vs. PHPStorm PHP Inspections

developer.php

<?php declare(strict_types=1);

final class DocumentFormatValidator
{
    private function validatePrefix(Filename $filename, DocumentFormat $format): void
    {
        $detectedPrefix = $this->detectPrefix($filename);

        if ($detectedPrefix === null) {
            if (!$format->requiresPrefix()) {
                return;
            }

            throw new DomainException('Missing prefix.');
        }

        if (!$format->requiresPrefix()) {
            throw new DomainException('Non required prefix detected.');
        }

        if (in_array($detectedPrefix->toString(), $format->prefixes, true)) {
            return;
        }

        throw new DomainException('Invalid prefix.');
    }
}

ide.php

<?php declare(strict_types=1);

final class DocumentFormatValidator
{
    private function validatePrefix(Filename $filename, DocumentFormat $format): void
    {
        $detectedPrefix = $this->detectPrefix($filename);

        if ($format->requiresPrefix()) {
            if ($detectedPrefix === null) {
                throw new DomainException('Missing prefix.');
            }

            if (!in_array($detectedPrefix->toString(), $format->prefixes, true)) {
                throw new DomainException('Invalid prefix.');
            }
        } else if ($detectedPrefix !== null) {
            throw new DomainException('Non required prefix detected.');
        }
    }
}

openai.php

<?php declare(strict_types=1);

final class DocumentFormatValidator
{
    private function validatePrefix(Filename $filename, DocumentFormat $format): void
    {
        $detectedPrefix = $this->detectPrefix($filename);

        if ($format->requiresPrefix()) {
            if ($detectedPrefix === null) {
                throw new DomainException('Missing prefix.');
            }

            if (!in_array($detectedPrefix->toString(), $format->prefixes, true)) {
                throw new DomainException('Invalid prefix.');
            }
        } else {
            if ($detectedPrefix !== null) {
                throw new DomainException('Non required prefix detected.');
            }
        }
    }

Original:

Originally my version looked similar to the others. But since I prefer "early returns" I removed any else-construct.

OpenAI:

This version of the code avoids unnecessary checks and throws exceptions only when necessary.

PHPStorm PHP Inspection: