Skip to content

Instantly share code, notes, and snippets.

@wildlyinaccurate

wildlyinaccurate/morph-module-checklist.md

Last active April 18, 2017 14:33
Show Gist options
  • Save wildlyinaccurate/abf3afb52cda4698df32bfd9a085dd69 to your computer and use it in GitHub Desktop.
Save wildlyinaccurate/abf3afb52cda4698df32bfd9a085dd69 to your computer and use it in GitHub Desktop.
Download ZIP
Morph module PR checklist
Raw
morph-module-checklist.md

JIRA Ticket

https://jira.dev.bbc.co.uk/browse/NEWS-0000

Other Related PRs

  • #0000

Checklist

Module Admin

  • Version bumped semantically (Usually in the package.json file)
  • Changelog updated (In the CHANGELOG.md file)
  • Module documentation updated if applicable (In the README.md file)

For all changes

  • CI tests pass (latest commit has a green tick)
  • E2E tests pass
  • New unit tests and E2E tests written, or tester has commented on PR to say no new tests are needed

For non-trivial front-end changes

  • Checked in all P1 desktop browsers
  • Axe finds no issues
  • bbc-a11y finds no issues (bbc-a11y http://localhost:8082/page/bbc-morph-this-module)
  • Screenshots at all breakpoints including core added to PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment